Fixing error PANIC: close of closed channelfor task.Stop()

mgmt/rest/client/client_func_test.go

@@ -457,6 +457,9 @@ func TestPulseClient(t *testing.T) {
 				p3 := c.CreateTask(&Schedule{Type: "simple", Interval: "1s"}, getWMFromSample("1.json"), "baron", true)
 				p4 := c.StartTask(p3.ID)
 				So(p4.Err.Error(), ShouldEqual, "error 0: Task is already running. ")
+
+				p5 := c.StartTask(p3.ID)
+				So(p5.Err.Error(), ShouldEqual, "error 0: Task is already running. ")
 			})
 			Convey("do returns err!=nil", func() {
 				port := -1
@@ -496,6 +499,9 @@ func TestPulseClient(t *testing.T) {
 				So(p3.Err, ShouldBeNil)
 				So(p4.ID, ShouldEqual, p3.ID)
 
+				p5 := c.StopTask(p3.ID)
+				So(p5.Err.Error(), ShouldEqual, "error 0: Task is already stopped. ")
+
 				b := make([]byte, 5)
 				rsp, err := c.do("PUT", fmt.Sprintf("/tasks/%v/stop", p1.ID), ContentTypeJSON, b)
 				So(rsp, ShouldNotBeNil)

scheduler/task.go

@@ -314,8 +314,10 @@ func (t *task) spin() {
 			}
 		case <-t.killChan:
 			// Only here can it truly be stopped
+			t.Lock()
 			t.state = core.TaskStopped
 			t.lastFireTime = time.Time{}
+			t.Unlock()
 			return
 		}
 	}