Added a stopping state for StopTask due to PANIC: close of closed cha…

…nnel
intelsdi-x · Oct 27, 2015 · 8c2533c · 8c2533c
1 parent 79007a0
commit 8c2533c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/core/task.go b/core/task.go
@@ -37,6 +37,7 @@ const (
 	TaskSpinning
 	TaskFiring
 	TaskEnded
+	TaskStopping
 )
 
 var (
@@ -46,6 +47,7 @@ var (
 		TaskSpinning: "Running",  // running
 		TaskFiring:   "Running",  // running (firing can happen so briefly we don't want to try and render it as a string state)
 		TaskEnded:    "Ended",    // ended, not resumable because the schedule will not fire again
+		TaskStopping: "Stopping", // channel has been closed, wait for TaskStopped state
 	}
 )
 

diff --git a/scheduler/task.go b/scheduler/task.go
@@ -211,6 +211,7 @@ func (t *task) Stop() {
 	t.Lock()
 	defer t.Unlock()
 	if t.state == core.TaskFiring || t.state == core.TaskSpinning {
+		t.state = core.TaskStopping
 		close(t.killChan)
 	}
 }