-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websocket #2173
Conversation
Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
Signed-off-by: 0ssigeno <s.berni@certego.net>
@0ssigeno I discussed with Matte about one thing to change. I'm going to tag you again in another message when i'll have done. |
intel_owl/settings/cache.py
Outdated
@@ -35,6 +35,8 @@ def get_where(self, starts_with: str, version=None) -> Dict[str, Any]: | |||
return self.get_many([row[0] for row in rows], version=version) | |||
|
|||
|
|||
DJANGO_REDIS_IGNORE_EXCEPTIONS = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reading the doc about this, I am not sure that's a good idea because if redis is down everything goes down. We can't ignore exceptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy pasted from @sevdog, we can clearly change it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drosetti after this check I think we can merge the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlodic removed
Co-authored-by: Matteo Lodi <30625432+mlodic@users.noreply.github.com>
Signed-off-by: 0ssigeno <s.berni@certego.net>
(Please add to the PR name the issue/s that this PR would close if merged by using a Github keyword. Example:
<feature name>. Closes #999
. If your PR is made by a single commit, please add that clause in the commit too. This is all required to automate the closure of related issues.)Description
Please include a summary of the change and link to the related issue.
Type of change
Please delete options that are not relevant.
Checklist
develop
_monkeypatch()
was used in its class to apply the necessary decorators.dumpplugin
command and added it in the project as a data migration. ("How to share a plugin with the community")test_files.zip
and you added the default tests for that mimetype in test_classes.py.FREE_TO_USE_ANALYZERS
playbook by following this guide.Black
,Flake
,Isort
) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.tests
folder). All the tests (new and old ones) gave 0 errors.Important Rules