This repository has been archived by the owner on Apr 18, 2023. It is now read-only.
[Example] code refactor for image classification #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huningxin @Wenzhao-Xiang @pinzhenx please review. |
Promise<void> loadModel(object model) downloads the model and label files, then decode the bytes to a JS object rawModel internally. Promise<DOMString> init(DOMString backend, DOMString prefer) converts the rawModel to a WebNN model and returns 'SUCCESS'. Returns 'NOT_LOADED' if the loadModel has not been finished and do nothing. 2. Full partial refresh without page reloading when switching models 3. Other UI changes
|
@huningxin @Wenzhao-Xiang @pinzhenx please review the latest version with seperated loadModel from init by @pinzhenx's. If no problem, please merge the code. |
1. add model.html page 2. remove model description section by mouse events 3. disable same model reloading from ui
|
@ibelem I also test the new example in Android platform with WASM (Pixel2, chrome 71), and unexpected to found all the image classification models passed(The old one can't pass ResnetV2(Onnx) #441 )! It's really a good improvement! |
|
Great job done! Thanks @ibelem @Wenzhao-Xiang @pinzhenx for the coding and review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #422
Please visit image_classification/README.md for more details.