Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Add a skip list for ARC display card on windows platform. #828

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

cfgfung
Copy link
Contributor

@cfgfung cfgfung commented Aug 27, 2024

It is found that the SYCL compiler on Windows will remove extra FP64-related functions. This will trigger Windows-specific UT failures. This is a list of functions that will trigger unexpected failures. Adding this can avoid unnecessary false alarms at this moment. The compiler problem has been reported to related teams.

@daisyden daisyden self-requested a review August 27, 2024 12:31
Copy link
Contributor

@daisyden daisyden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cfgfung cfgfung added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit 17b2696 Aug 27, 2024
2 of 3 checks passed
@cfgfung cfgfung deleted the raymond/UT_FP64_Win_ARC branch August 27, 2024 18:27
ZhiweiYan-96 pushed a commit that referenced this pull request Aug 28, 2024
…828)

It is found that the SYCL compiler on Windows will remove extra
FP64-related functions. This will trigger Windows-specific UT failures.
This is a list of functions that will trigger unexpected failures.
Adding this can avoid unnecessary false alarms at this moment. The
compiler problem has been reported to related teams.

Co-authored-by: min-jean-cho <min.jean.cho@intel.com>
ZhiweiYan-96 pushed a commit that referenced this pull request Aug 28, 2024
…828)

It is found that the SYCL compiler on Windows will remove extra
FP64-related functions. This will trigger Windows-specific UT failures.
This is a list of functions that will trigger unexpected failures.
Adding this can avoid unnecessary false alarms at this moment. The
compiler problem has been reported to related teams.

Co-authored-by: min-jean-cho <min.jean.cho@intel.com>
ZhiweiYan-96 pushed a commit that referenced this pull request Aug 28, 2024
commit f26d5c8
Author: Daisy Deng <daisy.deng@intel.com>
Date:   Wed Aug 28 13:32:32 2024 +0800

    add hook to avoid fp64 issues in input (#829)

    Add hook to avoid the case failures on ARC by avoid creating float64
    input:
    test_ops_xpu.py::TestCommonXPU::test_compare_cpu_cat_xpu_bfloat16 can
    pass with hook to reference_inputs_cat()
    test_ops_xpu.py::TestCommonXPU::test_compare_cpu_index_put_xpu_bfloat16
    with hook to index_variable()

    test_ops_xpu.py::TestCommonXPU::test_compare_cpu_log_softmax_with_dtype_xpu_bfloat16
    with hook to sample_inputs_softmax_variant()

    ---------

    Co-authored-by: Zhong, Ruijie <ruijie.zhong@intel.com>

commit 17b2696
Author: cfgfung <cfgfung@gmail.com>
Date:   Tue Aug 27 11:27:21 2024 -0700

    [Windows] Add a skip list for ARC display card on windows platform. (#828)

    It is found that the SYCL compiler on Windows will remove extra
    FP64-related functions. This will trigger Windows-specific UT failures.
    This is a list of functions that will trigger unexpected failures.
    Adding this can avoid unnecessary false alarms at this moment. The
    compiler problem has been reported to related teams.

    Co-authored-by: min-jean-cho <min.jean.cho@intel.com>
ZhiweiYan-96 pushed a commit that referenced this pull request Aug 30, 2024
…828)

It is found that the SYCL compiler on Windows will remove extra
FP64-related functions. This will trigger Windows-specific UT failures.
This is a list of functions that will trigger unexpected failures.
Adding this can avoid unnecessary false alarms at this moment. The
compiler problem has been reported to related teams.

Co-authored-by: min-jean-cho <min.jean.cho@intel.com>
github-merge-queue bot pushed a commit that referenced this pull request Sep 3, 2024
fengyuan14 pushed a commit that referenced this pull request Sep 3, 2024
…rm (#860)

Cherry pick for release/2.5. 
Details of the commit can be checked in
#828
ZhiweiYan-96 pushed a commit that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants