Add Aten::max_pool3d forward/backward #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chunhuanMeng
commented
Aug 22, 2024
•
chunhuanMeng
commented
- Aten:max_pool3d forward
- Aten:max_pool3d backward
majing921201
reviewed
Sep 5, 2024
| int width_group_range = ceil_div<int>(owidth, width_group_size); | ||
| int height_group_range = ceil_div<int>(oheight, height_group_size); | ||
|
|
||
| int z_group_range = totalZ > 65535 ? 65535 : totalZ; |
There was a problem hiding this comment.
65535 is CUDA's restriction for grid size. SYCL doesn't need.
so we can 1, remove this loop.
2, use max work item per tile as global range per loop.
majing921201
reviewed
Sep 5, 2024
| int width_group_range = ceil_div<int>(owidth, width_group_size); | ||
| int height_group_range = ceil_div<int>(oheight, height_group_size); | ||
|
|
||
| int z_group_range = totalZ > 65535 ? 65535 : totalZ; |
majing921201
reviewed
Sep 5, 2024
| } | ||
| } | ||
|
|
||
| void max_pool3d_with_indices_kernel( |
There was a problem hiding this comment.
move this function above "max_pool3d_with_indices_backward_kernel", follow PyTorch coding style
majing921201
reviewed
Sep 5, 2024
| } | ||
|
|
||
| template <typename scalar_t> | ||
| struct MaxPool3dWithIndicesOutFrameImplKernelFunctor { |
There was a problem hiding this comment.
MaxPool3dKerenlFunctor
majing921201
reviewed
Sep 5, 2024
| } | ||
|
|
||
| template <typename scalar_t> | ||
| struct MaxPool3dWithIndicesBackwardOutFrameImplKernelFunctor { |
There was a problem hiding this comment.
MaxPool3dBackwardKernelFunctor
xytintel
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.