minor changes to support testing on windows #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please apply the same changes in |
min-jean-cho
approved these changes
Aug 27, 2024
|
@fengyuan14, please take a look, thanks. |
daisyden
reviewed
Aug 29, 2024
|
Please help to ensure the Linux test result with the same number of PASSED, SKIPPED and XFAIL as before. |
min-jean-cho
pushed a commit
that referenced
this pull request
Aug 30, 2024
min-jean-cho
added a commit
that referenced
this pull request
Aug 30, 2024
fengyuan14
pushed a commit
that referenced
this pull request
Aug 31, 2024
cherry-pick #790 --------- Co-authored-by: sandeep.polisetty@intel.com <sandeep.polisetty@intel.com>
ZhiweiYan-96
pushed a commit
that referenced
this pull request
Sep 3, 2024
The following changes are made to support testing on windows. 1. Changing single quote to double quite for system call 2. separating setting environment variables in windows and linux --------- Co-authored-by: min-jean-cho <min.jean.cho@intel.com> Co-authored-by: Cheng, Penghui <penghui.cheng@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are made to support testing on windows.