Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS OpenMP and input validation fixes #1338

Merged

Conversation

Alexsandruss
Copy link
Contributor

@Alexsandruss Alexsandruss commented Jun 20, 2023

Changes:

  • Disable openmp test for sklearn main branch testing on macOS
  • Increase time limit to 2h for testing
  • Deselect KMeans FutureWarning test for sklearn 1.4
  • Fix input validation for patched functions

For fixed sklearn main branch testing see this job

Solves:

FAILED tests/test_build.py::test_openmp_parallelism_enabled
File "/usr/share/miniconda/envs/CB/lib/python3.10/site-packages/daal4py/sklearn/model_selection/_split.py", line 261, in <module>
    train_test_split = validate_params({
TypeError: validate_params() missing 1 required keyword-only argument: 'prefer_skip_nested_validation'

@Alexsandruss Alexsandruss changed the title MacOS OpenMP fix MacOS OpenMP and input validation fixes Jun 26, 2023
@Alexsandruss Alexsandruss force-pushed the dev/sklearn-macos-ci-openmp-fix branch from 97eacde to 9f6a223 Compare June 26, 2023 13:46
@Alexsandruss
Copy link
Contributor Author

For sklearn main branch testing see this previous job

@Alexsandruss Alexsandruss marked this pull request as ready for review June 28, 2023 14:01
@Alexsandruss Alexsandruss merged commit 9eb6afe into intel:master Jun 28, 2023
15 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants