This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
add assert for signature length check to stop API misuse. #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyao1
reviewed
Dec 25, 2023
| fn ecc_signature_bin_to_der( | ||
| signature: &[u8], | ||
| der_signature: &mut [u8], | ||
| curve_algo: SpdmBaseAsymAlgo, |
There was a problem hiding this comment.
I dont think we need to add curve_algo.
We just need to check sig.len() == NIST_P256_LEN or NIST_P384_LEN.
There was a problem hiding this comment.
I dont think we need to add curve_algo. We just need to check sig.len() == NIST_P256_LEN or NIST_P384_LEN.
updated.
longlongyang
force-pushed
the
curvecheck
branch
2 times, most recently
from
1a78c6f
to
9bccd70
Compare
Signed-off-by: Yang, Longlong <longlong.yang@intel.com>
longlongyang
force-pushed
the
curvecheck
branch
from
9bccd70
to
e30a1f8
Compare
longlongyang
changed the title
jyao1
approved these changes
Dec 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, function ecc_signature_bin_to_der use the short definite length DER encoding, the length of data in the V field must be <= 127 octets. While for the current set of supported curves, this should always be the case, this may change in the future. To prevent the API misuse, this PR add assert check for the signature length.