Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert db7696e and 4a88836 #427

Merged
merged 1 commit into from
May 17, 2023
Merged

revert db7696e and 4a88836 #427

merged 1 commit into from
May 17, 2023

Conversation

wenju-he
Copy link
Contributor

llvm-related variable initialization, clang::ExecuteCompilerInvocation and llvm-spirv aren't thread safe, at least for 90 branch.

@wenju-he
revert db7696e and 4a88836
7642a00 
llvm-related variable initialization, clang::ExecuteCompilerInvocation
and llvm-spirv aren't thread safe, at least for 90 branch.
@wenju-he wenju-he requested review from cdai2, fzou1 and haonanya May 16, 2023 04:20
haonanya
haonanya reviewed May 16, 2023
View reviewed changes
Copy link
Contributor

@haonanya haonanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also found the similar issue when investigate openvino benchmark crash.

@haonanya
Copy link
Contributor

haonanya commented May 16, 2023 •
edited
Loading

pre-CI doesn't work due to lack of ubuntu-18.04 machine, I am updating CI #432.

@wenju-he wenju-he marked this pull request as draft May 16, 2023 07:28
@wenju-he wenju-he marked this pull request as ready for review May 17, 2023 00:16
@wenju-he wenju-he closed this May 17, 2023
@wenju-he wenju-he reopened this May 17, 2023
@wenju-he
Copy link
Contributor Author

synced with @haonanya , ignore the 'waiting' task

@wenju-he wenju-he merged commit 76bc7f9 into intel:ocl-open-90 May 17, 2023
@wenju-he wenju-he deleted the ocl-open-90 branch May 17, 2023 03:12
wenju-he added a commit to wenju-he/opencl-clang that referenced this pull request Jun 1, 2023
@wenju-he
revert db7696e and 4a88836 (intel#427)
9ddfe48 
llvm-related variable initialization, clang::ExecuteCompilerInvocation
and llvm-spirv aren't thread safe.

(cherry picked from commit 76bc7f9)
wenju-he added a commit to wenju-he/opencl-clang that referenced this pull request Jun 1, 2023
@wenju-he
revert db7696e and 4a88836 (intel#427)
c16a7ad 
llvm-related variable initialization, clang::ExecuteCompilerInvocation
and llvm-spirv aren't thread safe, at least for 90 branch.

(cherry picked from commit 76bc7f9)
wenju-he added a commit to wenju-he/opencl-clang that referenced this pull request Jun 1, 2023
@wenju-he
revert db7696e and 4a88836 (intel#427)
e49922e 
llvm-related variable initialization, clang::ExecuteCompilerInvocation
and llvm-spirv aren't thread safe, at least for 90 branch.

(cherry picked from commit 76bc7f9)
wenju-he added a commit to wenju-he/opencl-clang that referenced this pull request Jun 1, 2023
@wenju-he
revert db7696e and 4a88836 (intel#427)
bf7a9a2 
llvm-related variable initialization, clang::ExecuteCompilerInvocation
and llvm-spirv aren't thread safe, at least for 90 branch.

(cherry picked from commit 76bc7f9)
wenju-he added a commit to wenju-he/opencl-clang that referenced this pull request Jun 1, 2023
@wenju-he
revert db7696e and 4a88836 (intel#427)
5c7fac4 
llvm-related variable initialization, clang::ExecuteCompilerInvocation
and llvm-spirv aren't thread safe, at least for 90 branch.

(cherry picked from commit 76bc7f9)
wenju-he added a commit to wenju-he/opencl-clang that referenced this pull request Jun 1, 2023
@wenju-he
revert db7696e and 4a88836 (intel#427)
b9cd1d2 
llvm-related variable initialization, clang::ExecuteCompilerInvocation
and llvm-spirv aren't thread safe, at least for 90 branch.

(cherry picked from commit 76bc7f9)
wenju-he added a commit that referenced this pull request Jun 1, 2023
@wenju-he
revert db7696e and 4a88836 (#427)
a7c9499 
llvm-related variable initialization, clang::ExecuteCompilerInvocation
and llvm-spirv aren't thread safe, at least for 90 branch.

(cherry picked from commit 76bc7f9)
wenju-he added a commit to wenju-he/opencl-clang that referenced this pull request Jun 1, 2023
@wenju-he
revert db7696e and 4a88836 (intel#427)
fc6098c 
llvm-related variable initialization, clang::ExecuteCompilerInvocation
and llvm-spirv aren't thread safe, at least for 90 branch.

(cherry picked from commit 76bc7f9)
wenju-he added a commit that referenced this pull request Jun 1, 2023
@wenju-he
revert db7696e and 4a88836 (#427) (#449)
53b8f12 
llvm-related variable initialization, clang::ExecuteCompilerInvocation
and llvm-spirv aren't thread safe, at least for 90 branch.

(cherry picked from commit 76bc7f9)
wenju-he added a commit that referenced this pull request Jun 1, 2023
@wenju-he
revert db7696e and 4a88836 (#427) (#446)
5639fd9 
llvm-related variable initialization, clang::ExecuteCompilerInvocation
and llvm-spirv aren't thread safe.

(cherry picked from commit 76bc7f9)
wenju-he added a commit that referenced this pull request Jun 1, 2023
@wenju-he
revert db7696e and 4a88836 (#427) (#447)
cf77b19 
llvm-related variable initialization, clang::ExecuteCompilerInvocation
and llvm-spirv aren't thread safe, at least for 90 branch.

(cherry picked from commit 76bc7f9)
wenju-he added a commit that referenced this pull request Jun 1, 2023
@wenju-he
revert db7696e and 4a88836 (#427) (#448)
b72f84d 
llvm-related variable initialization, clang::ExecuteCompilerInvocation
and llvm-spirv aren't thread safe, at least for 90 branch.

(cherry picked from commit 76bc7f9)
wenju-he added a commit that referenced this pull request Jun 1, 2023
@wenju-he
revert db7696e and 4a88836 (#427) (#450)
cbf2d1c 
llvm-related variable initialization, clang::ExecuteCompilerInvocation
and llvm-spirv aren't thread safe, at least for 90 branch.

(cherry picked from commit 76bc7f9)
wenju-he added a commit that referenced this pull request Jun 1, 2023
@wenju-he
revert db7696e and 4a88836 (#427) (#451)
bf37b13 
llvm-related variable initialization, clang::ExecuteCompilerInvocation
and llvm-spirv aren't thread safe, at least for 90 branch.

(cherry picked from commit 76bc7f9)
wenju-he added a commit that referenced this pull request Jun 1, 2023
@wenju-he
revert db7696e and 4a88836 (#427) (#452)
fe06526 
llvm-related variable initialization, clang::ExecuteCompilerInvocation
and llvm-spirv aren't thread safe, at least for 90 branch.

(cherry picked from commit 76bc7f9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haonanya haonanya haonanya left review comments

@cdai2 cdai2 Awaiting requested review from cdai2

@fzou1 fzou1 Awaiting requested review from fzou1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wenju-he @haonanya