Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESIMD] Enable -fsycl-esimd-force-stateless-mem by default #9452

Merged
merged 8 commits into from
Feb 16, 2024
Merged

[ESIMD] Enable -fsycl-esimd-force-stateless-mem by default #9452

merged 8 commits into from
Feb 16, 2024

Conversation

v-klochkov
Copy link
Contributor

No description provided.

@v-klochkov v-klochkov temporarily deployed to aws May 13, 2023 04:36 — with GitHub Actions Inactive
@v-klochkov v-klochkov force-pushed the esimd_force_stateless_default_switch branch from f991261 to 00f54e1 Compare June 6, 2023 22:51
@v-klochkov v-klochkov force-pushed the esimd_force_stateless_default_switch branch from 00f54e1 to 8f83a53 Compare June 17, 2023 02:00
@v-klochkov v-klochkov temporarily deployed to aws June 17, 2023 02:10 — with GitHub Actions Inactive
@v-klochkov v-klochkov force-pushed the esimd_force_stateless_default_switch branch from 8f83a53 to 7e4e545 Compare June 17, 2023 02:21
@v-klochkov v-klochkov temporarily deployed to aws June 17, 2023 02:30 — with GitHub Actions Inactive
@v-klochkov v-klochkov force-pushed the esimd_force_stateless_default_switch branch 2 times, most recently from d5e9ec9 to 9ecf445 Compare June 17, 2023 08:56
@v-klochkov v-klochkov temporarily deployed to aws June 17, 2023 09:11 — with GitHub Actions Inactive
@v-klochkov v-klochkov force-pushed the esimd_force_stateless_default_switch branch from 9ecf445 to e6b35d7 Compare August 3, 2023 06:04
@v-klochkov v-klochkov temporarily deployed to aws August 3, 2023 06:17 — with GitHub Actions Inactive
@v-klochkov v-klochkov temporarily deployed to aws August 3, 2023 07:53 — with GitHub Actions Inactive
@v-klochkov v-klochkov force-pushed the esimd_force_stateless_default_switch branch 2 times, most recently from 7da2b70 to af9cec8 Compare August 4, 2023 18:08
@v-klochkov v-klochkov temporarily deployed to aws August 4, 2023 18:23 — with GitHub Actions Inactive
@v-klochkov v-klochkov temporarily deployed to aws August 4, 2023 19:35 — with GitHub Actions Inactive
@v-klochkov v-klochkov force-pushed the esimd_force_stateless_default_switch branch 3 times, most recently from 9615ed2 to 2465dec Compare August 9, 2023 03:43
@v-klochkov v-klochkov force-pushed the esimd_force_stateless_default_switch branch 2 times, most recently from 60df6fb to 4a6a364 Compare August 18, 2023 00:22
@v-klochkov
[ESIMD] Enable -fsycl-esimd-force-stateless-mem by default
44094f8 
Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
@v-klochkov
Support 64-bit offset in scalar_load() and scalar_store()
5d41fad 
Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
@v-klochkov
Fix simd_view_copy_move_assign.cpp testt
6559fad 
Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
@v-klochkov
Fix the test intrins_trans.cpp
c67e786 
Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
@v-klochkov v-klochkov force-pushed the esimd_force_stateless_default_switch branch from 4a6a364 to c67e786 Compare August 22, 2023 19:48
@v-klochkov v-klochkov marked this pull request as ready for review August 24, 2023 18:42
@v-klochkov v-klochkov requested review from a team as code owners August 24, 2023 18:42
@v-klochkov v-klochkov marked this pull request as draft August 24, 2023 18:42
mdtoguchi
mdtoguchi reviewed Aug 24, 2023
View reviewed changes
clang/lib/Driver/ToolChains/Clang.cpp Outdated Show resolved Hide resolved
clang/lib/Driver/ToolChains/Clang.cpp Outdated Show resolved Hide resolved
@v-klochkov v-klochkov mentioned this pull request Sep 5, 2023
Merged
v-klochkov added a commit that referenced this pull request Sep 6, 2023
@v-klochkov
[ESIMD] Prepare for enabling of enforcing of stateless memory mode (#…
0da723f 
…10931)

* Support 64-bit offset if scalar_load() and scalar_store()
* Fix simd_view_copy_move_assign.cpp test
* Fix the test intrins_trans.cpp

This patch is only the preliminary step to final enabling of
force-stateless-memory mode that should be finalized here:
#9452

Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
@v-klochkov v-klochkov marked this pull request as ready for review February 15, 2024 20:02
@v-klochkov @premanandrao
Update clang/test/Preprocessor/sycl-esimd-force-stateless-mem.cpp
6e20adf 
Co-authored-by: premanandrao <premanand.m.rao@intel.com>
premanandrao
premanandrao approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v-klochkov v-klochkov marked this pull request as draft February 15, 2024 23:47
@v-klochkov v-klochkov marked this pull request as ready for review February 16, 2024 04:17
@v-klochkov v-klochkov merged commit f316273 into intel:sycl Feb 16, 2024
11 checks passed
@v-klochkov v-klochkov deleted the esimd_force_stateless_default_switch branch February 16, 2024 13:55
@mmeterel
Copy link

@v-klochkov Is this going to be part of 2024.1 release?

@v-klochkov
Copy link
Contributor Author

@v-klochkov Is this going to be part of 2024.1 release?

It is too late for 2024.1, it will be in 2024.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@premanandrao premanandrao premanandrao approved these changes

@mdtoguchi mdtoguchi mdtoguchi approved these changes

@fineg74 fineg74 fineg74 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@v-klochkov @mmeterel @premanandrao @mdtoguchi @fineg74