[SYCL] Fix usage of uninitialized variable in device_impl #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MType variable is not initialized for the host device. The patch changes several device_impl methods to avoid using MType if a device is a host one. Signed-off-by: Vlad Romanov <vlad.romanov@intel.com>
romanovvlad
commented
Nov 12, 2019
| @@ -74,17 +74,19 @@ class device_impl { | |||
| /// Check if device is a CPU device | |||
| /// | |||
| /// @return true if SYCL device is a CPU device | |||
| bool is_cpu() const { return (MType == PI_DEVICE_TYPE_CPU); } | |||
| bool is_cpu() const { return (!is_host() && (MType == PI_DEVICE_TYPE_CPU)); } | |||
There was a problem hiding this comment.
Not sure it's right approach. Probably the right approach would be to add new device type(host) to _pi_device_type enum. What do you think?
There was a problem hiding this comment.
I don't think PI wants to cover "host". It is rather interface for offloading. So I think what you are doing is preferable, but is it really OK that we return false in all of these for "host"? Should we return true for is_cpu()?
There was a problem hiding this comment.
@smaslov-intel technically, host device is not CPU, it is host. But I agree with your point about covering host on PI.
There was a problem hiding this comment.
OK, then I am OK with the fix.
smaslov-intel
approved these changes
Nov 13, 2019
| @@ -74,17 +74,19 @@ class device_impl { | |||
| /// Check if device is a CPU device | |||
| /// | |||
| /// @return true if SYCL device is a CPU device | |||
| bool is_cpu() const { return (MType == PI_DEVICE_TYPE_CPU); } | |||
| bool is_cpu() const { return (!is_host() && (MType == PI_DEVICE_TYPE_CPU)); } | |||
There was a problem hiding this comment.
OK, then I am OK with the fix.
vmaksimo
pushed a commit
to vmaksimo/llvm
that referenced
this pull request
Nov 30, 2020
At this point LoopControlParameters can be empty only if a single metadata llvm.loop.ivdep.enable is attached to a branch instruction. Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MType variable is not initialized for the host device. The patch
changes several device_impl methods to avoid using MType if a
device is a host one.
Signed-off-by: Vlad Romanov vlad.romanov@intel.com