[SYCL] Fixes for subbuffer reinterpretation #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes several problems: 1) There was no proper dependency for AllocaSubBuffer. When accessor to subbuffer was instantiated and was passed to kernel created with OpenCL interoperability, correct cl_mem object wasn't found which forced kernel argument to be nullptr. 2) Memory range wasn't passed in buffer constructor in `reinterpret` function. This led to unexpected behavior after data transmission from device to host. We can pass the same memory range only in cases when reinterpret dimension equals to source dimension. For other cases `reinterpret` didn't change its behaviour. Signed-off-by: Ivan Karachun <ivan.karachun@intel.com>
romanovvlad
previously approved these changes
Sep 12, 2019
Signed-off-by: Ivan Karachun <ivan.karachun@intel.com>
romanovvlad
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes several problems:
subbuffer was instantiated and was passed to kernel created with OpenCL
interoperability, correct cl_mem object wasn't found which forced
kernel argument to be nullptr.
reinterpretfunction.This led to unexpected behavior after data transmission from device to host.
We can pass the same memory range only in cases when reinterpret dimension
equals to source dimension.
For other cases
reinterpretdidn't change its behaviour.Signed-off-by: Ivan Karachun ivan.karachun@intel.com