Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][CUDA] Adds PI CUDA support for reqd_work_group_size attribute #3735

Merged
merged 12 commits into from
Jul 16, 2021
Merged

[SYCL][CUDA] Adds PI CUDA support for reqd_work_group_size attribute #3735

merged 12 commits into from
Jul 16, 2021

Commits on Jul 16, 2021

  1. [SYCL][CUDA] Adds PI CUDA support for reqd_work_group_size attribute 

    This commit adds support for reqd_work_group_size in the PI CUDA backend
by extracting the attribute as program metadata. The program metadata
accompanies the binary when passed to the backend and it is up to the
backend if they extract any useful metadata. This adds two additional
parameters to piProgramCreateWithBinary for passing the program
metadata.

Program metadata is transported as a properties created by
sycl-post-link, so this commit also changes the behaviour of the NVPTX
path for linkage actions leading to the offload wrapper. These changes
uses file tables for the NVPTX path as well to allow generation and
preservation of properties. This assumes that the file table only ever
contains a single row if taking the NVPTX path and will fail otherwise.

Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
    Steffen Larsen committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    483ce9c View commit details
    Browse the repository at this point in the history

  2. Fix driver offload test and minor changes 

    Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
    Steffen Larsen committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    de11767 View commit details
    Browse the repository at this point in the history

  3. Adjusting for feedback and more testing 

    Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
    Steffen Larsen committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    a6ccafc View commit details
    Browse the repository at this point in the history

  4. Remove redundant check 

    Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
    Steffen Larsen committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    4b04b37 View commit details
    Browse the repository at this point in the history

  5. Documentation changed to reflect post-link step changes 

    Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
    Steffen Larsen committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    5e829f1 View commit details
    Browse the repository at this point in the history

  6. Make copy_single_file a transformation 

    Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
    Steffen Larsen committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    40dd00c View commit details
    Browse the repository at this point in the history

  7. Adjusts updateCellValue parameters, comments, and errors 

    Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
    Steffen Larsen committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    25eef45 View commit details
    Browse the repository at this point in the history

  8. Change code-splitting TODO 

    Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
    Steffen Larsen committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    c952da0 View commit details
    Browse the repository at this point in the history

  9. Added assertion for 3 reqd_work_group_size metadata operands 

    Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
    Steffen Larsen committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    177c14d View commit details
    Browse the repository at this point in the history

  10. Adds piProgramCreateWithBinary comment and makes new parameters more … 

    …consistent

Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
    Steffen Larsen committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    c817325 View commit details
    Browse the repository at this point in the history

  11. Fix formatting 

    Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
    Steffen Larsen committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    76ad746 View commit details
    Browse the repository at this point in the history

  12. Fix sycl-offload-amdgcn test 

    Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
    Steffen Larsen committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    5fda49a View commit details
    Browse the repository at this point in the history