[SYCL] Move devicelib req mask collection into a LLVM pass #3291
Conversation
Signed-off-by: gejin <ge.jin@intel.com>
|
Fallback device library 'on-demand' loading mechanism requires offline analysis of user's input device image to find out all fallback device libraries (spv) needed in runtime and the offline analysis is done in sycl-post-link. Currently, the analysis implementation is in sycl-post-link.cpp which is not the best practice since sycl-post-link.cpp should only include the implementation itself. This PR aims to move the analysis into a LLVM module pass, the sycl-post-link.cpp will on be responsible for running this pass but includes no actual implementation. |
| }; | ||
|
|
||
| using SYCLDeviceLibFuncMap = std::unordered_map<std::string, DeviceLibExt>; | ||
| class SYCLDeviceLibReqMaskPass : public ModulePass { |
There was a problem hiding this comment.
Since this pass is designed for a legacy pass manager, could you please rename it to SYCLDeviceLibReqMaskLegacyPass? Or even better, rewrite it to use new pass manager infrastructure
There was a problem hiding this comment.
Hi, @AlexeySachkov
I agree it is better to use new pass manager but it looks like legacy pass manager has already been used in sycl-post-link.cpp in several places, I would like to use legacy pass manager in this patch and draft a new patch to replace all legacy pass manager with new pass manager.
Thanks very much.
Signed-off-by: gejin <ge.jin@intel.com>
|
/summary:run |
Signed-off-by: gejin ge.jin@intel.com