Skip to content

[SYCL] Pass NDRDescT to CGExecKernel::CGExecKernel() by reference #19728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from
Open

[SYCL] Pass NDRDescT to CGExecKernel::CGExecKernel() by reference #19728

wants to merge 3 commits into from
+4 −5

Conversation

Alexandr-Konovalov
Copy link
Contributor

NDRDescT contains several std::array-s, so copying is slower and std::move() has no effect.

@Alexandr-Konovalov
[SYCL] Pass NDRDescT to CGExecKernel::CGExecKernel() by reference
deb9b9a 
NDRDescT contains several std::array-s, so copying is slower and
std::move() has no effect.
@Alexandr-Konovalov Alexandr-Konovalov marked this pull request as ready for review August 7, 2025 05:28
@Alexandr-Konovalov Alexandr-Konovalov requested a review from a team as a code owner August 7, 2025 05:28
maarquitos14
maarquitos14 approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maarquitos14 maarquitos14 maarquitos14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alexandr-Konovalov @maarquitos14