[SYCL] Detect ze call leaking in E2E tests #19710
Conversation
jiezzhang
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
| def check_leak(output): | ||
| keyword_found = False | ||
| for line in output.splitlines(): | ||
| if keyword_found and "LEAK" in line: |
There was a problem hiding this comment.
Just FYI, we already have a lit var %{l0_leak_check} which a bunch of the tests still use (instead of UR_L0_LEAKS_DEBUG ). It gets replaced by the env var in the final invocation, but I'm not sure if this python script here will detect.
I think that l0_leak_check directive is no longer needed and probably could be replaced by the actual env var. It's in hundreds of tests right now.
There was a problem hiding this comment.
I think the tests that set the env var (either directly or by using %{l0_leak_check}) already check for absence of "LEAK" (--implicit-check-not=LEAK) so we don't have to check it again here. As far as I understand this is only needed when the user decides to run all the tests with leak checking (e.g. passing --param ur_l0_leaks_debug=1 to lit).
jiezzhang
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
jiezzhang
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Pretty sure the failed test is not caused by this PR. @cperkinsintel is it a known flaky issue? |
After #19328, UR_L0_LEAKS_DEBUG stop throwing exceptions when leaks are detected so LIT can't report failures. Add a leak checking in format.py to keep "--param ur_l0_leaks_debug=1" work as before.