[NFCI][SYCL] Stop owning platform_impl from device_impl
#19613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Refactoring has started in intel#18143 intel#18251 but this final step wasn't performed before due to some unittests failing. Seems not to be the case anymore.
aelovikov-intel
force-pushed
the
plt-dev-own
branch
from
6afa94e to
2911148
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
Jul 29, 2025
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jul 29, 2025
Similar to intel#19613. Refactoring has started in intel#18143 intel#18251 This didn't work back then due to some unittests failing (because `global_handler` shutdown is different with unittests) but it doesn't seem to be an issue any more, probably due to other refactoring PRs that prefer raw ptr/refs over `std::shared_ptr` elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring has started in
#18143
#18251
but this final step wasn't performed before due to some unittests failing. Seems not to be the case anymore.