Skip to content

[SYCL] Align Non-Uniform Groups with PR#14604 #19238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Jul 30, 2025
+1,296 −1,217
Merged

[SYCL] Align Non-Uniform Groups with PR#14604 #19238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
74047b6
[SYCL] Align Non-Uniform Groups with PR#14604:
Jul 1, 2025
244962d
[SYCL] Fixed missing code formatting
Jul 1, 2025
4737295
[SYCL ] Update AddSecurityFlags.cmake for wip
AndreiZibrov Jul 1, 2025
1e1a6e7
Update sycl/include/sycl/detail/spirv.hpp
AndreiZibrov Jul 1, 2025
f2a2bc5
Update sycl/include/sycl/ext/oneapi/experimental/fragment.hpp
AndreiZibrov Jul 1, 2025
0b8eba3
[SYCL] Fix review findings
Jul 2, 2025
88d35d9
[SYCL] getting rid of throwing
Jul 2, 2025
a7d9fb6
[SYCL] Remove rest of fixed_size_group leftover + refactored macros w…
Jul 2, 2025
84d9636
Update sycl/include/sycl/ext/oneapi/experimental/tangle.hpp
AndreiZibrov Jul 2, 2025
78208f8
[SYCL] Fixed formatting after refactoring
Jul 2, 2025
63c2ec8
[SYCL] Remove left empty namespace + fix empty lines / comment format…
Jul 2, 2025
92bddb3
[SYCL] Fix unreached leftovers didn't reach by tests recently
Jul 2, 2025
6ba16c9
[SYCL] move has_extension fix to separate PR
Jul 2, 2025
0d3da76
[SYCL] Fix missing include
Jul 2, 2025
c5a48c9
[SYCL] bringing back missed comment
AndreiZibrov Jul 2, 2025
4fbb2b8
[SYCL] Formatting missed include line
Jul 2, 2025
c4f9c37
[SYCL] Fix include missing by CI
Jul 2, 2025
502ac66
[SYCL] Fix missing namespace for is_chunk_v trait
Jul 2, 2025
7639a7b
[SYCL] Fixed wrong namespace ref
Jul 2, 2025
de45c92
Update sycl/include/sycl/ext/oneapi/experimental/cuda/non_uniform_alg…
steffenlarsen Jul 24, 2025
16f4ec3
Merge remote-tracking branch 'intel/sycl' into HEAD
steffenlarsen Jul 24, 2025
62082ce
Remove redundant test requirements
steffenlarsen Jul 24, 2025
251f0b6
Remove unintentional tangle from CUDA min aspect requirements
steffenlarsen Jul 24, 2025
a7ec622
Remove unnecessary alias
steffenlarsen Jul 24, 2025
1fbf327
Add SYCL_EXT_ONEAPI_TANGLE
steffenlarsen Jul 24, 2025
f7e6184
Add additional partition group support
steffenlarsen Jul 25, 2025
843df18
Address small comments
steffenlarsen Jul 25, 2025
ede8a48
Fix build failure and attempt to fix new test
steffenlarsen Jul 25, 2025
e916346
Clean up is_* traits
steffenlarsen Jul 28, 2025
e3e556a
Remove last (void) cast
steffenlarsen Jul 28, 2025
3889570
Adhere to weird formatter requirement
steffenlarsen Jul 28, 2025
6b9ed74
Update sycl/include/sycl/ext/oneapi/experimental/fragment.hpp
steffenlarsen Jul 29, 2025
4d18c85
Apply suggestions from code review
steffenlarsen Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions llvm/include/llvm/SYCLLowerIR/DeviceConfigFile.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,9 @@ def AspectExt_oneapi_unique_addressing_per_dim : Aspect<"ext_oneapi_unique_addre
def AspectExt_oneapi_bindless_images_sample_1d_usm : Aspect<"ext_oneapi_bindless_images_sample_1d_usm">;
def AspectExt_oneapi_bindless_images_sample_2d_usm : Aspect<"ext_oneapi_bindless_images_sample_2d_usm">;
def AspectExt_intel_esimd : Aspect<"ext_intel_esimd">;
def AspectExt_oneapi_ballot_group : Aspect<"ext_oneapi_ballot_group">;
def AspectExt_oneapi_fixed_size_group : Aspect<"ext_oneapi_fixed_size_group">;
def AspectExt_oneapi_opportunistic_group : Aspect<"ext_oneapi_opportunistic_group">;
def AspectExt_oneapi_tangle_group : Aspect<"ext_oneapi_tangle_group">;
def AspectExt_oneapi_fragment : Aspect<"ext_oneapi_fragment">;
def AspectExt_oneapi_chunk : Aspect<"ext_oneapi_chunk">;
def AspectExt_oneapi_tangle : Aspect<"ext_oneapi_tangle">;
def AspectExt_intel_matrix : Aspect<"ext_intel_matrix">;
def AspectExt_oneapi_is_composite : Aspect<"ext_oneapi_is_composite">;
def AspectExt_oneapi_is_component : Aspect<"ext_oneapi_is_component">;
Expand Down Expand Up @@ -155,8 +154,8 @@ def : TargetInfo<"__TestAspectList",
AspectExt_oneapi_bindless_sampled_image_fetch_3d,
AspectExt_oneapi_bindless_images_gather,
AspectExt_intel_esimd,
AspectExt_oneapi_ballot_group, AspectExt_oneapi_fixed_size_group, AspectExt_oneapi_opportunistic_group,
AspectExt_oneapi_tangle_group, AspectExt_intel_matrix, AspectExt_oneapi_is_composite, AspectExt_oneapi_is_component,
AspectExt_oneapi_fragment, AspectExt_oneapi_chunk,
AspectExt_oneapi_tangle, AspectExt_intel_matrix, AspectExt_oneapi_is_composite, AspectExt_oneapi_is_component,
AspectExt_oneapi_graph, AspectExt_oneapi_limited_graph, AspectExt_oneapi_private_alloca,
AspectExt_oneapi_queue_profiling_tag, AspectExt_oneapi_virtual_mem, AspectExt_oneapi_cuda_cluster_group,
AspectExt_intel_fpga_task_sequence,
Expand All @@ -181,9 +180,9 @@ def : TargetInfo<"__TestDeprecatedAspectList",
defvar IntelCpuAspects = [
AspectCpu, AspectFp16, AspectFp64, AspectQueue_profiling, AspectAtomic64,
AspectExt_oneapi_srgb, AspectExt_oneapi_native_assert,
AspectExt_intel_legacy_image, AspectExt_oneapi_ballot_group,
AspectExt_oneapi_fixed_size_group, AspectExt_oneapi_opportunistic_group,
AspectExt_oneapi_tangle_group, AspectExt_oneapi_private_alloca,
AspectExt_intel_legacy_image, AspectExt_oneapi_fragment,
AspectExt_oneapi_chunk,
AspectExt_oneapi_tangle, AspectExt_oneapi_private_alloca,
AspectOnline_compiler, AspectOnline_linker, AspectExt_intel_gpu_slices,
AspectExt_intel_gpu_subslices_per_slice, AspectExt_intel_gpu_eu_count_per_subslice,
AspectExt_intel_gpu_hw_threads_per_eu, AspectExt_intel_device_id,
Expand All @@ -207,9 +206,9 @@ defvar Fp16Fp64Atomic64 = [AspectFp16, AspectFp64, AspectAtomic64];
defvar Fp16Atomic64 = [AspectFp16, AspectAtomic64];
defvar Sg8_16_32 = [8, 16, 32];
defvar Sg16_32 = [16, 32];
defvar IntelGPUBaseAspects = [AspectExt_intel_esimd, AspectExt_oneapi_ballot_group,
AspectExt_oneapi_fixed_size_group, AspectExt_oneapi_opportunistic_group,
AspectExt_oneapi_tangle_group];
defvar IntelGPUBaseAspects = [AspectExt_intel_esimd, AspectExt_oneapi_fragment,
AspectExt_oneapi_chunk,
AspectExt_oneapi_tangle];
class IntelTargetInfo<string Name, list<Aspect> Aspects, list<int> subGroupSizesList>
: TargetInfo<Name, IntelGPUBaseAspects # Aspects, subGroupSizesList>;
// Note: only the "canonical" target names are listed here - see
Expand Down Expand Up @@ -283,8 +282,8 @@ defvar CudaSM90USMAspects = [AspectUsm_system_allocations, AspectUsm_atomic_host
defvar CudaMinAspects = !listconcat(CudaMinUSMAspects, [AspectGpu, AspectFp64, AspectOnline_compiler, AspectOnline_linker,
AspectQueue_profiling, AspectExt_intel_pci_address, AspectExt_intel_memory_bus_width,
AspectExt_intel_device_info_uuid, AspectExt_oneapi_native_assert, AspectExt_intel_free_memory, AspectExt_intel_device_id,
AspectExt_intel_memory_clock_rate, AspectExt_oneapi_ballot_group, AspectExt_oneapi_fixed_size_group,
AspectExt_oneapi_opportunistic_group, AspectExt_oneapi_graph, AspectExt_oneapi_limited_graph]);
AspectExt_intel_memory_clock_rate, AspectExt_oneapi_fragment, AspectExt_oneapi_chunk,
AspectExt_oneapi_graph, AspectExt_oneapi_limited_graph]);
// Bindless images aspects are partially supported on CUDA and disabled by default at the moment.
defvar CudaBindlessImagesAspects = [AspectExt_oneapi_bindless_images, AspectExt_oneapi_bindless_images_shared_usm,
AspectExt_oneapi_bindless_images_1d_usm, AspectExt_oneapi_bindless_images_2d_usm, AspectExt_oneapi_external_memory_import,
Expand Down
Loading