Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][E2E] Refactor check_device_code/group_[load|store].cpp tests #16462

Merged
merged 3 commits into from
Dec 23, 2024
Merged

[SYCL][E2E] Refactor check_device_code/group_[load|store].cpp tests #16462

merged 3 commits into from
Dec 23, 2024

Conversation

aelovikov-intel
Copy link
Contributor

So that CHECKs could be re-generated without manual intervention.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner December 23, 2024 21:30
@aelovikov-intel
Copy link
Contributor Author

To reviewers: I've uploaded this PR as two commits. The final state is fully auto-generated CHECKs, but the diff is hard to follow. As such, I've introduced an intermediate commit that manually repositions chunks of code to resemble the old version more.

I think reviewing this on per-commit bases will be much easier than do it all at once.

@aelovikov-intel
Copy link
Contributor Author

@intel/llvm-reviewers-runtime , Chris is OOO, can someone else take a look please? It should make downstream pulldowns much smoother.

@jsji
Copy link
Contributor

jsji commented Dec 23, 2024

@intel/llvm-reviewers-runtime , Chris is OOO, can someone else take a look please? It should make downstream pulldowns much smoother.

Thanks @aelovikov-intel for improving the maintainability !

jsji
jsji reviewed Dec 23, 2024
View reviewed changes
sycl/test/check_device_code/group_load.cpp Outdated
@@ -1,4 +1,4 @@
// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --functions "group_load" --include-generated-funcs --version 4
// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
// NOTE: and manually adjusted to follow the related explicit instantiation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this note if CHECKs are now fully automated

@aelovikov-intel aelovikov-intel merged commit 2824f61 into intel:sycl Dec 23, 2024
15 checks passed
@aelovikov-intel aelovikov-intel deleted the block-load-store-test branch December 23, 2024 23:37
sarnex pushed a commit to sarnex/llvm that referenced this pull request Dec 24, 2024
@aelovikov-intel @sarnex
[SYCL][E2E] Refactor check_device_code/group_[load|store].cpp tests (…
e86540e 
…intel#16462)

So that `CHECK`s could be re-generated without manual intervention.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsji jsji jsji left review comments

@uditagarwal97 uditagarwal97 uditagarwal97 approved these changes

@cperkinsintel cperkinsintel Awaiting requested review from cperkinsintel cperkinsintel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aelovikov-intel @jsji @uditagarwal97