[SYCL][Matrix] Extend W/A for more corner cases of AccessChain usage #16370
+168
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
YuriPlyakhin
force-pushed
the
AccessChainWOs
branch
from
068c6f3 to
63eb10c
Compare
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
force-pushed
the
AccessChainWOs
branch
from
63eb10c to
44db814
Compare
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
The new corner case is: AccessChain is used on arrays of Joint Matrices and in loops
YuriPlyakhin
force-pushed
the
AccessChainWOs
branch
from
44db814 to
57dbccd
Compare
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
approved these changes
Dec 24, 2024
| if (StopOnGEP && isa<GetElementPtrInst>(GEP)) | ||
| return V; | ||
| V = GEP->getPointerOperand(); | ||
| } else if (Operator::getOpcode(V) == Instruction::BitCast) { |
There was a problem hiding this comment.
can we not use dyn_cast here?
Comment on lines
+65
to
+66
| if (Value *RV = Call->getReturnedArgOperand()) { | ||
| V = RV; |
There was a problem hiding this comment.
this is for sret right? should we assert it's a pointer?
| if (auto *Call = dyn_cast<CallBase>(V)) { | ||
| if (Value *RV = Call->getReturnedArgOperand()) { | ||
| V = RV; | ||
| continue; |
There was a problem hiding this comment.
can you add a comment explaining this continue?
| if (!WrapperMatrixTy) | ||
| return nullptr; | ||
| TargetExtType *MatrixTy = | ||
| dyn_cast<TargetExtType>(WrapperMatrixTy->getElementType(0)); |
There was a problem hiding this comment.
nit: we could use dyn_cast_or_null to get rid of the if right above
| if (!MatrixTy) | ||
| return nullptr; | ||
| StringRef Name = MatrixTy->getName(); | ||
| if (Name != MATRIX_TYPE) |
There was a problem hiding this comment.
nit: can we move the getName() call into the if since we never use the Name variable again and IMO its clear whats going on?
| // __spirv_AccessChain | ||
| // First we check if the argument came from a GEP instruction | ||
| GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>( | ||
| stripPointerCastsAndOffsets(CI->getArgOperand(0), true)); |
There was a problem hiding this comment.
nit: can we add an inline comment explaining what the true is, like /*StopOnGEPs=*/true
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new corner case is: AccessChain is used on arrays of Joint Matrices
Fix for CMPLRLLVM-64465