Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Graph] Only get command handle for updatable command-buffers #15522

Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from

Conversation

Bensuo
Copy link
Contributor

@Bensuo Bensuo commented Sep 26, 2024

  • Update UR tag to include changes to command-handles
  • Update calls to UrCommandBufferAppendKernelLaunch to only request command handles for updatable command-buffers
  • Only store command handles for updatable command-graphs

UR PR: oneapi-src/unified-runtime#2131

Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sycl/source/detail/scheduler/commands.cpp Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
- Update UR tag to include changes to command-handles
- Update calls to UrCommandBufferAppendKernelLaunch to only request command handles for updatable command-buffers
- Only store command handles for updatable command-graphs
- Update UR commit tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants