[SYCL] Fix diagnostic about non-external function/variable #15372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were issuing a diagnostic when applying attributes like [[sycl_device]]
or [[intel::device_indirectly_callable]] on functions/variables without
external linkage - but the diagnostic text assumed that this occurred
only with static entities or entities within unnamed namespaces.
The following example demonstrates a case where the previous
diagnostic text was misleading:
```
namespace {
struct S {};
}
[[sycl_device]] void foo(S);
```
premanandrao
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
premanandrao
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
elizabethandrews
approved these changes
Sep 13, 2024
smanna12
approved these changes
Sep 13, 2024
premanandrao
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
premanandrao
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers - this is ready for a merge. The failing test is unrelated and seems to be an infrastructure issue. |
@intel/llvm-gatekeepers - ping. |
|
the error isnt an infra issue, its because the time between build and test was too long so the build artifacts got deleted |
|
i'd prefer we rerun build+test, ill do that now |
|
fail is fixed in head, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were issuing a diagnostic when applying attributes like [[sycl_device]] or [[intel::device_indirectly_callable]] on functions/variables without external linkage - but the diagnostic text assumed that this occurred only with static entities or entities within unnamed namespaces.
The following example demonstrates a case where the previous diagnostic text was misleading: