[SYCL][E2E] Use %threads_lib expansion instead of custom expansion in Graph test
#15370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayylol
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
ayylol
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
approved these changes
Sep 12, 2024
|
Failure is unrelated and covered with github issue. |
|
@intel/sycl-graphs-reviewers Could you please take a look. |
EwanC
approved these changes
Sep 16, 2024
|
@intel/llvm-gatekeepers This is ready to merge. The failure is unrelated - #15341 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes custom expansion only used in this test, in favor of using %threads_lib. The custom expansion used
-pthreadexplicitly, which produced an unknown argument warning when running using the clang-cl driver.