-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Run E2E tests on PVC on postcommit #15308
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
had a problem deploying
to
WindowsCILock
September 5, 2024 21:44 — with
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
September 5, 2024 22:06 — with
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
September 5, 2024 22:06 — with
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
September 6, 2024 00:04 — with
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
September 7, 2024 15:31 — with
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
September 7, 2024 15:31 — with
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
September 7, 2024 15:31 — with
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
September 7, 2024 17:01 — with
GitHub Actions
Failure
uditagarwal97
had a problem deploying
to
WindowsCILock
September 7, 2024 17:01 — with
GitHub Actions
Failure
Need to update CI container first to test changes in this PR: #15324 |
uditagarwal97
had a problem deploying
to
WindowsCILock
September 12, 2024 22:38 — with
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
September 12, 2024 22:38 — with
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
September 12, 2024 22:38 — with
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
September 12, 2024 22:50 — with
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
September 12, 2024 23:11 — with
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
September 12, 2024 23:11 — with
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
December 23, 2024 19:01 — with
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
December 23, 2024 19:01 — with
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
December 23, 2024 19:01 — with
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
December 23, 2024 19:26 — with
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
December 23, 2024 19:44 — with
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
December 23, 2024 22:51 — with
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
December 23, 2024 22:52 — with
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
December 23, 2024 22:52 — with
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
December 23, 2024 23:09 — with
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
December 23, 2024 23:38 — with
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
December 24, 2024 16:02 — with
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
December 24, 2024 16:02 — with
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
December 24, 2024 16:03 — with
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
December 24, 2024 16:17 — with
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
December 24, 2024 16:37 — with
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
December 24, 2024 16:45 — with
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
December 24, 2024 16:46 — with
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
December 24, 2024 16:50 — with
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
December 24, 2024 17:00 — with
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
December 24, 2024 17:25 — with
GitHub Actions
Inactive
@intel/llvm-gatekeepers I think we are good to merge this PR. The following test failure on PVC w/ igc dev is unrelated and an existing PR (#16452) is there to mark it XFAIL on PVC.
|
sarnex
pushed a commit
to sarnex/llvm
that referenced
this pull request
Dec 24, 2024
This PR enables running E2E tests on PVC in the post-commit. Currently, the latest PVC driver hangs when a large number of jobs are submitted to it in parallel. Due to this, E2E tests might timeout spuriously on PVC. The PVC bug is being tracked internally via GSD-10241. To prevent spurious test timeouts, we restrict the number of parallel E2E test runs on PVC and to prevent disruption in CI, we are currently enabling PVC in post-commit only. When the bug gets fixed, we can move PVC testing to pre-commit.
sarnex
pushed a commit
that referenced
this pull request
Jan 3, 2025
#15308 added PVC to post-commit. Since then, we have not seen any spurious E2E test timeouts on PVC, so testing on PVC seems stable enough to be moved to pre-commit. Running E2E tests on PVC takes only about 5 minutes so moving PVC testing to pre-commit shouldn't cause any noticeable slowdown in pre commit testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables running E2E tests on PVC in the post-commit.
Currently, the latest PVC driver hangs when a large number of jobs are submitted to it in parallel. Due to this, E2E tests might timeout spuriously on PVC. The PVC bug is being tracked internally via GSD-10241. To prevent spurious test timeouts, we restrict the number of parallel E2E test runs on PVC and to prevent disruption in CI, we are currently enabling PVC in post-commit only. When the bug gets fixed, we can move PVC testing to pre-commit.