[SYCL-E2E] Re-enable a bunch of working tests #14915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
ross/ifs_test
branch
from
e9c142a
to
21d1989
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
ross/ifs_test
branch
from
21d1989
to
c6056d0
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
changed the title
dkhaldi
reviewed
Aug 6, 2024
There was a problem hiding this comment.
Since the issue has been resolved, please make sure you don't xfail the two other tests in SG32 for PVC as mentioned in #14598 (comment)
None of the SG32 tests were marked as XFAIL as part of the PI->UR work as far as I can tell. EDIT: Or if they were, those XFAILs have been removed since. |
uditagarwal97
approved these changes
Aug 7, 2024
|
@intel/llvm-gatekeepers Please merge when possible, Thanks! |
This was referenced Aug 8, 2024
|
@RossBrunton - It doesn't appear that Github is smart enough to auto-close the last 3 linked issues, like it was able to auto-close #14795. Not a big deal, just an interesting note in case it becomes relevant in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 14795, 14749, 14804, 14805