-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Doc] Remove overloads for kernel properties #14785
base: sycl
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@intel/llvm-reviewers-runtime: I think it would make sense to deprecate the parallel_for
and single_task
overloads that are removed from the spec in this PR. We can then remove then entirely later.
The deprecation message should point people to the new functions in sycl_ext_oneapi_enqueue_functions that were recently enabled in #14743. Tagging @steffenlarsen also as author of that PR.
@Pennycook: I suggest keeping this PR unmerged in "Draft" state until the deprecation messages are added.
sycl/doc/extensions/experimental/sycl_ext_oneapi_kernel_properties.asciidoc
Outdated
Show resolved
Hide resolved
@steffenlarsen - I'm trying to clear up a few things in my GitHub TODO list. Do you know whether the deprecation messages Greg mentioned above have been implemented, or when we're planning to deprecate those features? |
Updates the sycl_ext_oneapi_kernel_properties extension specification to align with both the current implementation and the behavior of the new sycl_ext_oneapi_enqueue_functions extension. Signed-off-by: John Pennycook <john.pennycook@intel.com>
5bec99f
to
f614f11
Compare
The enqueue functions in sycl_ext_oneapi_enqueue_functions provide an alternative interface for attaching kernel properties to a launch configuration, removing the need for these overloads. Signed-off-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
@Pennycook, you can track progress of deprecating legacy overloads in #16145 |
The overloads for `single_task` and `parallel_for` in the `sycl_ext_oneapi_kernel_properties` extension are being deprecated as mentioned in #14785. Updated tests containing such overloads so that they can still run after the deprecation. Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
This commit removes the parallel_for and single_task overloads from the sycl_ext_oneapi_kernel_properties extension.
The sycl_ext_oneapi_enqueue_functions extension provides an alternative interface for passing kernel properties that is more aligned with our expected long-term direction: specifically, it separates run-time launch properties from compile-time properties which affect kernel compilation, and it introduces new concepts to avoid the need for extra arguments.