Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UR] Bump UR and implement changes to bindless image handle types #14516

Merged
merged 4 commits into from
Jul 11, 2024
Merged

[UR] Bump UR and implement changes to bindless image handle types #14516

merged 4 commits into from
Jul 11, 2024

Conversation

callumfare
Copy link
Contributor

@callumfare callumfare commented Jul 10, 2024 •
edited by kbenzie
Loading

@callumfare callumfare mentioned this pull request Jul 10, 2024
Merged
@callumfare callumfare force-pushed the callum/bindless_image_native_handles branch from af9d329 to a0319c8 Compare July 10, 2024 12:03
@callumfare callumfare force-pushed the callum/bindless_image_native_handles branch 2 times, most recently from 0fe5f60 to 11422fc Compare July 10, 2024 14:54
przemektmalon
przemektmalon reviewed Jul 10, 2024
View reviewed changes
sycl/include/sycl/detail/pi.h Outdated Show resolved Hide resolved
sycl/plugins/cuda/pi_cuda.cpp Show resolved Hide resolved
@callumfare callumfare force-pushed the callum/bindless_image_native_handles branch from 11422fc to 4174505 Compare July 10, 2024 16:36
@callumfare callumfare force-pushed the callum/bindless_image_native_handles branch from 4174505 to c9176a5 Compare July 10, 2024 16:50
@callumfare callumfare force-pushed the callum/bindless_image_native_handles branch from c9176a5 to 0461e7e Compare July 11, 2024 09:00
@callumfare callumfare force-pushed the callum/bindless_image_native_handles branch from 0461e7e to 59d8977 Compare July 11, 2024 09:05
@kbenzie kbenzie marked this pull request as ready for review July 11, 2024 09:46
@kbenzie kbenzie requested review from a team as code owners July 11, 2024 09:46
PietroGhg
PietroGhg approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@PietroGhg PietroGhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native CPU LGTM, thank you

steffenlarsen
steffenlarsen approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Seanst98 Seanst98 mentioned this pull request Jul 11, 2024
Merged
@kbenzie
Copy link
Contributor

kbenzie commented Jul 11, 2024

@intel/llvm-gatekeepers please merge

@martygrant martygrant merged commit 44861fe into intel:sycl Jul 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbenzie kbenzie kbenzie approved these changes

@cppchedy cppchedy cppchedy approved these changes

@przemektmalon przemektmalon przemektmalon approved these changes

@PietroGhg PietroGhg PietroGhg approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@npmiller npmiller Awaiting requested review from npmiller npmiller was automatically assigned from intel/llvm-reviewers-cuda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@callumfare @kbenzie @cppchedy @przemektmalon @PietroGhg @steffenlarsen @martygrant