Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][NFCI][ABI-Break] Move handler members to impl #14460

Merged
merged 24 commits into from
Jul 16, 2024

Commits on Jul 5, 2024

  1. [SYCL][NFCI][ABI-Break] Move handler members to impl

    This moves some of the members in the handler class to its impl class.
    Doing so allows developers to change these arguments without breaking
    ABI. This also moves more implementation details, such as command-group
    classes, launch configuration information, argument information and
    HostTask tracking, into sources to avoid hard-to-find ABI breaks in the
    communication between headers and runtime library.
    
    In addition to this, the following improvements are made:
    * The HostKernel class has been simplified to no longer have call and
      runOnHost functions.
    * The HostTask wrapper class has been moved to sources and the owner
      has been changed from a unique_ptr to a shared_ptr, which prevents the
      need for including host_task_impl.hpp in odd places.
    
    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    steffenlarsen committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    98c691c View commit details
    Browse the repository at this point in the history
  2. Fix shallowing integer

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    steffenlarsen committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    5805367 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Configuration menu
    Copy the full SHA
    8878682 View commit details
    Browse the repository at this point in the history
  2. Fix failure

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    steffenlarsen committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    e339faf View commit details
    Browse the repository at this point in the history
  3. Move a few more members

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    steffenlarsen committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d93ef7b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4fa05e8 View commit details
    Browse the repository at this point in the history
  5. Fix AddLifetimeSharedPtrStorage arg

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    steffenlarsen committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    69abfe6 View commit details
    Browse the repository at this point in the history
  6. Fix padding

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    steffenlarsen committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d1ca544 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a2f49a5 View commit details
    Browse the repository at this point in the history
  8. Pad NDRDescT global size in NumWorkGroups case

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    steffenlarsen committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    5f99c91 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8fdfcdd View commit details
    Browse the repository at this point in the history
  10. Fix build issue

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    steffenlarsen committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ad2e20c View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Fix formatting and missed padding case

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    steffenlarsen committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    c389dc0 View commit details
    Browse the repository at this point in the history
  2. Move back to letting NDRDescT govern its padding

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    steffenlarsen committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    72f7fb6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc76694 View commit details
    Browse the repository at this point in the history
  4. Include interop handle header

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    steffenlarsen committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    adf52d4 View commit details
    Browse the repository at this point in the history
  5. Fix broken include paths

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    steffenlarsen committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    e51e47a View commit details
    Browse the repository at this point in the history
  6. Add back the case for interop_handle host_task

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    steffenlarsen committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    9b33cf5 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Add interop handler include on hip and cuda tests

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    steffenlarsen committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    1d9e1f5 View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary includes

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    steffenlarsen committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    a0aba15 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Configuration menu
    Copy the full SHA
    628ee06 View commit details
    Browse the repository at this point in the history
  2. Add Windows symbols and change namings to match other members

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    steffenlarsen committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    abb11cc View commit details
    Browse the repository at this point in the history
  3. Remove unreachable asserts causing Windows warnings

    The group class cannot be used in host code, but one of its ctors uses
    asserts that only work on host. These assertions use % and / on ranges
    and MSVC thinks that these could potentially cause division by 0. Since
    these are unreachable they can be safely removed.
    
    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    steffenlarsen committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    1a4f3a3 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Configuration menu
    Copy the full SHA
    affd0ba View commit details
    Browse the repository at this point in the history