Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Bindless][Exp] Remove const from non-reference and non-pointer type parameters #14238

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

isaacault
Copy link
Contributor

No description provided.

* Remove const from non-reference and non-pointer type parameters

(cherry picked from commit b73ddff7300f559f038307f83c9da6eea572ea27)
@isaacault isaacault requested a review from a team as a code owner June 20, 2024 09:12
@isaacault isaacault self-assigned this Jun 20, 2024
Copy link
Contributor

@cppchedy cppchedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

note that these updates are ABI breaking.

@isaacault
Copy link
Contributor Author

LGTM.

note that these updates are ABI breaking.

@cppchedy The symbols haven't changed, so I don't think it is.

@cppchedy
Copy link
Contributor

LGTM.
note that these updates are ABI breaking.

@cppchedy The symbols haven't changed, so I don't think it is.

@isaacault my bad. I thought adding/removing const will produce different symbols.

isaacault added a commit to codeplaysoftware/intel-llvm-mirror that referenced this pull request Jun 21, 2024
This is to proactively comply with PR intel#14238 [SYCL][Bindless][Exp]
Remove const from non-reference and non-pointer type parameters.
@isaacault
Copy link
Contributor Author

@intel/llvm-gatekeepers this is ready for merge.

@martygrant martygrant merged commit d4f2fe5 into intel:sycl Jun 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants