Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Fix post-commit issue with library dependencies #14094

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

AlexeySachkov
Copy link
Contributor

No description provided.

Copy link
Contributor

@maksimsab maksimsab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better than my approach.

@sarnex
Copy link
Contributor

sarnex commented Jun 7, 2024

Seems this doesn't work @AlexeySachkov

sycl-module-split: /__w/llvm/llvm/src/llvm/include/llvm/IR/PassManager.h:474: typename PassT::Result& llvm::AnalysisManager<IRUnitT, ExtraArgTs>::getResult(IRUnitT&, ExtraArgTs ...) [with PassT = llvm::PassInstrumentationAnalysis; IRUnitT = llvm::Module; ExtraArgTs = {}; typename PassT::Result = llvm::PassInstrumentation]: Assertion `AnalysisPasses.count(PassT::ID()) && "This analysis pass was not registered prior to being queried"' failed.

@AlexeySachkov
Copy link
Contributor Author

Seems this doesn't work @AlexeySachkov

sycl-module-split: /__w/llvm/llvm/src/llvm/include/llvm/IR/PassManager.h:474: typename PassT::Result& llvm::AnalysisManager<IRUnitT, ExtraArgTs>::getResult(IRUnitT&, ExtraArgTs ...) [with PassT = llvm::PassInstrumentationAnalysis; IRUnitT = llvm::Module; ExtraArgTs = {}; typename PassT::Result = llvm::PassInstrumentation]: Assertion `AnalysisPasses.count(PassT::ID()) && "This analysis pass was not registered prior to being queried"' failed.

Yeah, I didn't run tests locally, only build. But I've just pushed another commit which should fix this issue

@sarnex
Copy link
Contributor

sarnex commented Jun 7, 2024

Cool thx

Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @AlexeySachkov

@sarnex
Copy link
Contributor

sarnex commented Jun 7, 2024

CI is broken RN and this fixes build issues, so merging to unbreak build for everyone.

@sarnex sarnex merged commit 0e587ed into intel:sycl Jun 7, 2024
12 of 13 checks passed
ianayl pushed a commit to ianayl/sycl that referenced this pull request Jun 13, 2024
@AlexeySachkov AlexeySachkov deleted the private/asachkov/fix-post-commit branch October 9, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants