Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][COMPAT] Fix memory_management_test3 #14080

Merged
merged 2 commits into from
Jun 10, 2024
Merged

[SYCL][COMPAT] Fix memory_management_test3 #14080

merged 2 commits into from
Jun 10, 2024

Conversation

AidanBeltonS
Copy link
Contributor

This change is intended to fix a CI failure on the OpenCL backend for the memory_management_test3. This is because the memory is allocated on a different q to the one it is released on.

@AidanBeltonS AidanBeltonS requested a review from a team as a code owner June 6, 2024 14:17
@joeatodd
Copy link
Contributor

joeatodd commented Jun 6, 2024

@intel/llvm-gatekeepers this is ready to merge 🙏

@steffenlarsen
Copy link
Contributor

steffenlarsen commented Jun 7, 2024

@AidanBeltonS - The test was disabled for gen12 with #14087. Could you please remove that check as well, if this is believed to fix the issue?

Edit: And close #14086 if it does.

@steffenlarsen steffenlarsen merged commit d6a18e1 into sycl Jun 10, 2024
13 checks passed
ianayl pushed a commit to ianayl/sycl that referenced this pull request Jun 13, 2024
This change is intended to fix a CI failure on the OpenCL backend for
the `memory_management_test3`. This is because the memory is allocated
on a different q to the one it is released on.
@bader bader deleted the fix_mem_test3 branch September 17, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants