Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Joint Matrix] Test combinations are queried Part 4 #14019

Merged
merged 5 commits into from
Jun 6, 2024

Conversation

artemrad
Copy link
Contributor

@artemrad artemrad commented Jun 3, 2024

Supported matrix dimensions are queried from the device, and inform the tests which tile sizes one can use.

This is a subset of all tests that are planned to be modified.

Test manually tested on PVC and SPR - no new regresssions

The following tests have been marked as XFAIL on all platforms. I removed them from XMX8 folder. Once they are passing then they can be modified to query the supported matrix dimensions form the device.

  • joint_matrix_colA_rowB_colC.cpp
  • joint_matrix_out_bounds.cpp
  • joint_matrix_unaligned_k.cpp

@artemrad artemrad requested a review from a team as a code owner June 3, 2024 17:47
Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provided comments/questions

Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artemrad
Copy link
Contributor Author

artemrad commented Jun 5, 2024

@intel/llvm-gatekeepers ready to merge

@steffenlarsen steffenlarsen merged commit ad84669 into intel:sycl Jun 6, 2024
13 checks passed
ianayl pushed a commit to ianayl/sycl that referenced this pull request Jun 13, 2024
Supported matrix dimensions are queried from the device, and inform the
tests which tile sizes one can use.

This is a subset of all tests that are planned to be modified.

Test manually tested on PVC and SPR - no new regresssions

The following tests have been marked as XFAIL on all platforms. I
removed them from XMX8 folder. Once they are passing then they can be
modified to query the supported matrix dimensions form the device.
* joint_matrix_colA_rowB_colC.cpp
* joint_matrix_out_bounds.cpp
* joint_matrix_unaligned_k.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants