Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Fix XPTI FW lib path for test-e2e on Win #13986

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

KseniyaTikhomirova
Copy link
Contributor

@KseniyaTikhomirova KseniyaTikhomirova commented May 31, 2024

This PR helps to avoid hardcoded path symbols and let OS dependent tools to work with paths.
Original version produces path/....\lib\xptifw.lib which causes skip of library linkage on windows.
os.path.normpath is the main change here that helps to handle path separators properly.

Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please elaborate in the PR description on what the issue was and how this change addresses it. Maybe an example would help on how the code before was producing a wrong command-line/substitution.

@KseniyaTikhomirova
Copy link
Contributor Author

Please elaborate in the PR description on what the issue was and how this change addresses it. Maybe an example would help on how the code before was producing a wrong command-line/substitution.

done

@aelovikov-intel
Copy link
Contributor

CUDA testing failed due to infrastructure issues but I don't think it's required to re-run it to merge.

@aelovikov-intel aelovikov-intel merged commit 5b52793 into intel:sycl Jun 4, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants