-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Graph] Update begin_recording and end_recording #13480
Conversation
- Removes bool return value from being_recording() and end_recording() - Adds missing property_list parameter to the implementation of begin_recording()
There are unit tests that check the return value of begin/end recording, presumably those need updated as well? |
Yeah, I forgot to run those locally. Will update / delete them. |
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@intel/llvm-gatekeepers I think this is good to merge |
The bool return value was removed because there are no good usecases for it. The sycl way to handle errors is to return exceptions. The original reasoning to have a bool return value was that the application would likely ignore the exceptions in this entrypoint. There is no reason to believe that they will check the bool return either if it serves no practical purpose.
This is a breaking API change, but as the extension is in experimental status this is permissible.