Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Graph] Update begin_recording and end_recording #13480

Merged
merged 8 commits into from
Apr 26, 2024

Conversation

fabiomestre
Copy link
Contributor

@fabiomestre fabiomestre commented Apr 18, 2024

  • Removes bool return value from begin_recording() and end_recording()
  • Adds missing property_list parameter to the implementation of begin_recording()

The bool return value was removed because there are no good usecases for it. The sycl way to handle errors is to return exceptions. The original reasoning to have a bool return value was that the application would likely ignore the exceptions in this entrypoint. There is no reason to believe that they will check the bool return either if it serves no practical purpose.

This is a breaking API change, but as the extension is in experimental status this is permissible.

- Removes bool return value from being_recording() and end_recording()
- Adds missing property_list parameter to the implementation of begin_recording()
@fabiomestre fabiomestre marked this pull request as ready for review April 18, 2024 15:20
@fabiomestre fabiomestre requested a review from a team as a code owner April 18, 2024 15:20
@fabiomestre fabiomestre marked this pull request as draft April 18, 2024 15:20
@Bensuo
Copy link
Contributor

Bensuo commented Apr 18, 2024

There are unit tests that check the return value of begin/end recording, presumably those need updated as well?

@fabiomestre
Copy link
Contributor Author

There are unit tests that check the return value of begin/end recording, presumably those need updated as well?

Yeah, I forgot to run those locally. Will update / delete them.

Copy link
Contributor

@reble reble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EwanC
Copy link
Contributor

EwanC commented Apr 26, 2024

@intel/llvm-gatekeepers I think this is good to merge

@martygrant martygrant merged commit c65bed1 into intel:sycl Apr 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants