Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][E2E] Pass -std=c++17 to the compiler provided via -fsycl-host-compiler #13216

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

againull
Copy link
Contributor

Author: Marcos Maronas marcos.maronas@intel.com

…compiler

Author: Marcos Maronas <marcos.maronas@intel.com>
@bader
Copy link
Contributor

bader commented Mar 30, 2024

@againull, do we need this change?

@againull
Copy link
Contributor Author

againull commented Apr 1, 2024

@againull, do we need this change?

Yes, if gcc compiler is used which doesn't have c++17 enabled by default.

@againull againull merged commit 725b9f2 into intel:sycl Apr 1, 2024
13 checks passed
@bader
Copy link
Contributor

bader commented Apr 1, 2024

@againull, do we need this change?

Yes, if gcc compiler is used which doesn't have c++17 enabled by default.

Shouldn't DPC++ driver set C++ mode for the host compiler? It configures include paths, links runtime library already.
Tagging @mdtoguchi for awareness.

@mdtoguchi
Copy link
Contributor

@againull, do we need this change?

Yes, if gcc compiler is used which doesn't have c++17 enabled by default.

Shouldn't DPC++ driver set C++ mode for the host compiler? It configures include paths, links runtime library already. Tagging @mdtoguchi for awareness.

The driver doesn't make the C++17 assumption here as it requires an option. There are some assumptions we make in regards to options for headers and libraries for option names. Some determination would probably need to be done to make sure the option we are passing to set the std version is valid for the host compiler being used.

@againull againull deleted the explicit_std17 branch April 9, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants