Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][COMPAT] Memory Header cleanup #13143

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

Alcpz
Copy link
Contributor

@Alcpz Alcpz commented Mar 25, 2024

This PR cleanses up a the memory header to prepare for the next update:

  • device_memory wrapper now accepts a queue argument (to be consistent with the rest of the memory calls)
  • read_only usm property protected behind a feature macro
  • removed syclcompat:: verbosity from some internal implementations
  • Doxygen docs reviewed
  • Variable names improved (M -> Mem, D -> Dim, Val -> Value)

Copy link
Contributor

@AidanBeltonS AidanBeltonS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor LGTM

@Alcpz
Copy link
Contributor Author

Alcpz commented Apr 9, 2024

@intel/llvm-gatekeepers PR ready for merging. Thanks!

@sommerlukas sommerlukas merged commit d8c0a93 into intel:sycl Apr 9, 2024
12 checks passed
@Alcpz Alcpz deleted the Alcpz/memory-header-cleanup branch June 3, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants