Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][ESIMD] Implement scatter for local accessors accepting compile time properties #12675

Merged
merged 17 commits into from
Feb 16, 2024
Merged

[SYCL][ESIMD] Implement scatter for local accessors accepting compile time properties #12675

merged 17 commits into from
Feb 16, 2024

Conversation

fineg74
Copy link
Contributor

@fineg74 fineg74 commented Feb 9, 2024

No description provided.

@fineg74 fineg74 marked this pull request as ready for review February 9, 2024 05:49
@fineg74 fineg74 requested a review from a team as a code owner February 9, 2024 05:49
v-klochkov
v-klochkov reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@v-klochkov v-klochkov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have some comments though.

sycl/test-e2e/ESIMD/unified_memory_api/Inputs/scatter.hpp Outdated Show resolved Hide resolved
sycl/test-e2e/ESIMD/unified_memory_api/Inputs/scatter.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/ext/intel/esimd/memory.hpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2024 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@fineg74 fineg74 marked this pull request as draft February 13, 2024 04:26
@fineg74 fineg74 marked this pull request as ready for review February 14, 2024 23:48
@v-klochkov v-klochkov merged commit 27c9546 into intel:sycl Feb 16, 2024
11 checks passed
@fineg74 fineg74 deleted the localAccessorScatter branch February 16, 2024 17:17
@sommerlukas
Copy link
Contributor

One of the tests introduced in this PR fails on unrelated changes in post-commit: #12769

@sommerlukas sommerlukas mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-klochkov v-klochkov v-klochkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fineg74 @sommerlukas @v-klochkov