Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][ESIMD][E2E] Fix aot_mixed.cpp #12650

Merged
merged 1 commit into from
Feb 7, 2024
Merged

[SYCL][ESIMD][E2E] Fix aot_mixed.cpp #12650

merged 1 commit into from
Feb 7, 2024

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Feb 7, 2024

Arg was wrong. Manually tested this. CI is current broken because of this,

Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>
@sarnex sarnex marked this pull request as ready for review February 7, 2024 18:50
@sarnex sarnex requested a review from a team as a code owner February 7, 2024 18:50
@@ -7,9 +7,9 @@
//===----------------------------------------------------------------------===//
// TODO: Enable on other GPUs once internal ticket is fixed
// REQUIRES: ocloc && gpu-intel-gen12
// RUN: %clangxx -fsycl -fsycl-targets=spir64_gen -Xsycl-target-backend=spir64_gen -Xs "-device tgllp" -o %t.sycl.out -DENABLE_SYCL=0 %s
// RUN: %clangxx -fsycl -fsycl-targets=spir64_gen -Xsycl-target-backend=spir64_gen "-device tgllp" -o %t.sycl.out -DENABLE_SYCL=0 %s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is odd. In my notes that -Xs is required. Seems something has changed in driver, right?

Copy link
Contributor Author

@sarnex sarnex Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it's because we have -Xsycl-target-backend which is kind of similar to -Xs but lets you provide backend options for a specific target because we support compiling for multiple targets at once. -Xs will apply to all targets (I think), here it doesn't matter because there's only one. The current code is passing -Xs to the backend, which is wrong.

Like the use case is -Xsycl-target-backend=spir64 "foo" Xsycl-target-backend=spir64_gen "bar"

If you want to use -Xs only, drop -Xsycl-target-backend=spir64_gen "-device tgllp" and use -Xs "-device tgllp"

TLDR it's just the way the RUN command was originally written and I missed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants