[SYCL][Fusion] Take auxiliary resources from fused command groups #12593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #12556 (for test) |
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
sommerlukas
reviewed
Feb 5, 2024
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
This was referenced Feb 6, 2024
Reductions use auxiliary resources to handle reduction temporal buffers. Assign those auxiliary resources from each fused command group to the placeholder fusion event. This event will not be marked as completed after the fused reductions finish execution either if fusion is completed, cancelled or aborted. Test is updated to check every algorithm that is selected automatically by `sycl::reduction`, i.e., every supported algorithm. We also cover both cases (fusion taking and not taking place). Signed-off-by: Victor Perez <victor.perez@codeplay.com>
victor-eds
force-pushed
the
reduction-fix
branch
from
5310f23
to
f1e2b91
Compare
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bso-intel
approved these changes
Feb 7, 2024
sommerlukas
approved these changes
Feb 7, 2024
sycl/test-e2e/KernelFusion/Reduction/group_reduce_and_last_wg_detection.cpp
Show resolved
Hide resolved
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Related failure of post-commit: https://github.com/intel/llvm/actions/runs/7817537968/job/21327112200 #12621 should fix this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reductions use auxiliary resources to handle reduction temporal
buffers. Assign those auxiliary resources from each fused command
group to the placeholder fusion event. This event will not be marked
as completed after the fused reductions finish execution either if
fusion is completed, cancelled or aborted.
Test is updated to check every algorithm that is selected
automatically by
sycl::reduction, i.e., every supportedalgorithm. We also cover both cases (fusion taking and not taking
place).
Signed-off-by: Victor Perez victor.perez@codeplay.com