[UR][L0] move platform cache into the adapter structure #12403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
pbalcer
force-pushed
the
l0-platform-cache-fix
branch
from
81cbebb
to
73edc11
Compare
pbalcer
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
pushed a commit
that referenced
this pull request
Jan 17, 2024
The ur.hpp and ur.cpp files were moved to the unified runtime repo. This is currently blocking #12403, oneapi-src/unified-runtime#1252.
pbalcer
force-pushed
the
l0-platform-cache-fix
branch
from
73edc11
to
508cc08
Compare
pbalcer
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
pbalcer
added a commit
to pbalcer/llvm
that referenced
this pull request
Jan 18, 2024
Calling urAdapterGet is required for the global adapter to be initialized, but it was missing when creating a platform from a native handle. This meant that the adapter's state never got initialized and its refcount remained at 0 (and overflowed on teardown). This had no visible side-effects until changes in intel#12403.
|
The fail is due to #12432 |
aelovikov-intel
pushed a commit
that referenced
this pull request
Jan 18, 2024
…12432) Calling urAdapterGet is required for the global adapter to be initialized, but it was missing when creating a platform from a native handle. This meant that the adapter's state never got initialized and its refcount remained at 0 (and overflowed on teardown). This had no visible side-effects until changes in #12403.
Testing UR patch.
pbalcer
force-pushed
the
l0-platform-cache-fix
branch
from
508cc08
to
01fe96c
Compare
kbenzie
pushed a commit
that referenced
this pull request
Jan 22, 2024
…12432) Calling urAdapterGet is required for the global adapter to be initialized, but it was missing when creating a platform from a native handle. This meant that the adapter's state never got initialized and its refcount remained at 0 (and overflowed on teardown). This had no visible side-effects until changes in #12403.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing UR patch.