[SYCL][Graph] Support for Prefetch and memory advise #11474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for `prefetch` and `advise` memory hints. Adds e2e tests that verify that backend functions are called as they should be.
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mfrancepillois
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
… enqueuing commands to a command-buffer.
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mfrancepillois
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
EwanC
reviewed
Dec 5, 2023
…eble/llvm into command-buffer-prefetch-advise-support
|
ping @intel/llvm-reviewers-runtime for a review |
steffenlarsen
approved these changes
Jan 16, 2024
|
tagging @intel/llvm-gatekeepers for merging |
aelovikov-intel
pushed a commit
that referenced
this pull request
Jan 17, 2024
Fixes post-commit CI failure seen here https://github.com/intel/llvm/actions/runs/7559355777/job/20582987874 and caused by merging of #11474
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Jan 18, 2024
In intel#11474 it was noted in the documentation that the `prefetch` and `memadvise` handler methods were not supported as graph nodes on the OpenCL command-buffer backend. However, we never disabled the E2E tests for this target, which wasn't picked up by CI, as CI doesn't use the command-buffer extension in its OpenCL config. Correct this oversight.
ldrumm
pushed a commit
that referenced
this pull request
Jan 19, 2024
In #11474 it was noted in the documentation that the `prefetch` and `memadvise` handler methods were not supported as graph nodes on the OpenCL command-buffer backend. However, we never disabled the E2E tests for this target, which wasn't picked up by CI, as CI doesn't use the command-buffer extension in its OpenCL config. This PR corrects this oversight by marking the tests as unsupported for OpenCL.
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Feb 6, 2024
The merged PR intel#11472 added support for `handler::fill` and `handler::memset` nodes in a graph, while merged PR intel#11474 added support for `handler::prefetch` and `handler::mem_advise`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
prefetchandadvisememory hints.Adds e2e tests that verify that backend functions are called as they should be.