-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Opaque pointer] Enable INTEL_SYCL_OPAQUEPOINTER_READY #10888
Conversation
This PR depends on a change in https://github.com/intel/vc-intrinsics and #10779 . But I'd like to kick off the review first as this is a big PR that changes multiple components. Reviewers, please have a look. The plan is to enable this in sycl branch first, then flow it down to downstream branches, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the clang/test changes and they look okay to me.
Ping @intel/dpcpp-clang-driver-reviewers @intel/dpcpp-esimd-reviewers @intel/dpcpp-spirv-reviewers @intel/dpcpp-tools-reviewers @intel/llvm-reviewers-runtime . Most changes in these components are just test update, please have a look. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
esimd lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test changes in DPC++ Tools area looks good to me.
I do have a request for quick clarification for llvm-spirv changes here. Will it be possible to not make the changes directly here? We should be getting these changes as part of next pulldown from the Khronos SPIRV-LLVM-Translator repo. Adding @MrSidims and @jcranmer-intel for comment here.
Thanks a lot for putting up this major PR.
Thanks for the review. The SPIRV changes are here because these are local to |
CI failure in SYCL-Unit :: Extensions/./ExtensionsTests/CommandGraphTest/GetProfilingInfoExceptionCheck is a bug in sycl branch will be fixed in #10954 |
@asudarsa @MrSidims @jcranmer-intel @intel/dpcpp-spirv-reviewers Can you have a look? Hopefully we can get this merged today. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SPIR-V changes are in sync with open source. So we should be ok.
Thanks
Thanks @asudarsa ! @intel/llvm-gatekeepers Can we get this merged? Thank you! |
@intel/llvm-gatekeepers @bader OK to merge? Thank you! |
This is to enable -DINTEL_SYCL_OPAQUEPOINTER_READY=1 by default,
so that we can start to remove the old code already removed by community (those guarded within #ifndef INTEL_SYCL_OPAQUEPOINTER_READY ).