Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Opaque pointer] Enable INTEL_SYCL_OPAQUEPOINTER_READY #10888

Merged
merged 17 commits into from
Aug 28, 2023
Merged

[SYCL][Opaque pointer] Enable INTEL_SYCL_OPAQUEPOINTER_READY #10888

merged 17 commits into from
Aug 28, 2023

Conversation

jsji
Copy link
Contributor

@jsji jsji commented Aug 18, 2023

This is to enable -DINTEL_SYCL_OPAQUEPOINTER_READY=1 by default,
so that we can start to remove the old code already removed by community (those guarded within #ifndef INTEL_SYCL_OPAQUEPOINTER_READY ).

  • Set opauqe pointer ready
  • Add flag to tablegen
  • Remove opaque pointer from merge-extension-ivars.m
  • Port barrier_intrinsic.ll to opaque pointer
  • Remove intel-alloca-bitcast.ll as it is testing typed pointer path
  • Revert changes to InferAddressSpaces/AMDGPU/icmp.ll
  • Use private repo for testing purpose

@jsji jsji self-assigned this Aug 21, 2023
@jsji jsji changed the title [Opaque pointer] Enable INTEL_SYCL_OPAQUEPOINTER_READY [SYL][Opaque pointer] Enable INTEL_SYCL_OPAQUEPOINTER_READY Aug 22, 2023
@jsji jsji changed the title [SYL][Opaque pointer] Enable INTEL_SYCL_OPAQUEPOINTER_READY [SYCL][Opaque pointer] Enable INTEL_SYCL_OPAQUEPOINTER_READY Aug 22, 2023
@jsji jsji marked this pull request as ready for review August 23, 2023 14:59
@jsji jsji requested review from a team as code owners August 23, 2023 14:59
@jsji jsji requested a review from againull August 23, 2023 14:59
@jsji
Copy link
Contributor Author

jsji commented Aug 23, 2023

This PR depends on a change in https://github.com/intel/vc-intrinsics and #10779 .
I'll update the corresponding commits (aa4b3af ) once they are merged.

But I'd like to kick off the review first as this is a big PR that changes multiple components.

Reviewers, please have a look. The plan is to enable this in sycl branch first, then flow it down to downstream branches,
then come back to sycl branch and remove the code within #ifndef INTEL_SYCL_OPAQUEPOINTER_READY and flow it down again.

Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the clang/test changes and they look okay to me.

@jsji
Copy link
Contributor Author

jsji commented Aug 24, 2023

Ping @intel/dpcpp-clang-driver-reviewers @intel/dpcpp-esimd-reviewers @intel/dpcpp-spirv-reviewers @intel/dpcpp-tools-reviewers @intel/llvm-reviewers-runtime .

Most changes in these components are just test update, please have a look. Thanks.
The plan is to merge this before EOD tomorrow. Thanks.

Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esimd lgtm

@sarnex sarnex requested a review from a team August 24, 2023 20:34
Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes in DPC++ Tools area looks good to me.
I do have a request for quick clarification for llvm-spirv changes here. Will it be possible to not make the changes directly here? We should be getting these changes as part of next pulldown from the Khronos SPIRV-LLVM-Translator repo. Adding @MrSidims and @jcranmer-intel for comment here.

Thanks a lot for putting up this major PR.

@jsji
Copy link
Contributor Author

jsji commented Aug 25, 2023

Test changes in DPC++ Tools area looks good to me. I do have a request for quick clarification for llvm-spirv changes here. Will it be possible to not make the changes directly here? We should be getting these changes as part of next pulldown from the Khronos SPIRV-LLVM-Translator repo. Adding @MrSidims and @jcranmer-intel for comment here.

Thanks a lot for putting up this major PR.

Thanks for the review. The SPIRV changes are here because these are local to sycl branch, we have removed the opaque pointer options in KhronosGroup/SPIRV-LLVM-Translator repo, but we added (kept) these options due to migration, this is to remove them so that we can in sync with KhronosGroup/SPIRV-LLVM-Translator repo again.

@jsji
Copy link
Contributor Author

jsji commented Aug 25, 2023

CI failure in SYCL-Unit :: Extensions/./ExtensionsTests/CommandGraphTest/GetProfilingInfoExceptionCheck is a bug in sycl branch will be fixed in #10954

@jsji
Copy link
Contributor Author

jsji commented Aug 25, 2023

@asudarsa @MrSidims @jcranmer-intel @intel/dpcpp-spirv-reviewers Can you have a look? Hopefully we can get this merged today. :)

Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPIR-V changes are in sync with open source. So we should be ok.

Thanks

@jsji
Copy link
Contributor Author

jsji commented Aug 26, 2023

Thanks @asudarsa ! @intel/llvm-gatekeepers Can we get this merged? Thank you!

@jsji
Copy link
Contributor Author

jsji commented Aug 28, 2023

@intel/llvm-gatekeepers @bader OK to merge? Thank you!

@jsji jsji requested a review from bader August 28, 2023 18:33
@bader bader merged commit a47705f into intel:sycl Aug 28, 2023
9 checks passed
aelovikov-intel pushed a commit that referenced this pull request Sep 6, 2023
…QUEPOINTER_READY (#11059)

- Remove code in INTEL_SYCL_OPAQUEPOINTER_READY==0
- clang-format

This should be NFC, as INTEL_SYCL_OPAQUEPOINTER_READY is always 1 since
#10888 .
aelovikov-intel pushed a commit that referenced this pull request Sep 8, 2023
…INTER_READY (#11063)

- Remove code guarded in ifndef INTEL_SYCL_OPAQUEPOINTER_READY

This should be NFC, as INTEL_SYCL_OPAQUEPOINTER_READY is always 1 since
#10888 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants