Skip to content

Commit

Permalink
[Telemetry] Add missing virtual destructors (#121015)
Browse files Browse the repository at this point in the history
Fixes warnings after #121003.
  • Loading branch information
vitalybuka authored Dec 24, 2024
1 parent 9ab5474 commit 9d0a5d4
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions llvm/include/llvm/Telemetry/Telemetry.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ namespace telemetry {

class Serializer {
public:
virtual ~Serializer() = default;

virtual Error init() = 0;
virtual void write(StringRef KeyName, bool Value) = 0;
virtual void write(StringRef KeyName, StringRef Value) = 0;
Expand Down Expand Up @@ -62,6 +64,8 @@ class Serializer {
/// This struct can be extended as needed to add additional configuration
/// points specific to a vendor's implementation.
struct Config {
virtual ~Config() = default;

// If true, telemetry will be enabled.
const bool EnableTelemetry;
Config(bool E) : EnableTelemetry(E) {}
Expand Down Expand Up @@ -132,6 +136,8 @@ class Destination {
/// monitored and transmitting the data elsewhere.
class Manager {
public:
virtual ~Manager() = default;

// Optional callback for subclasses to perform additional tasks before
// dispatching to Destinations.
virtual Error preDispatch(TelemetryInfo *Entry) = 0;
Expand Down

0 comments on commit 9d0a5d4

Please sign in to comment.