Skip to content

Commit

Permalink
[lldb][NFC] Update documentation of Handle[Argument]Completion
Browse files Browse the repository at this point in the history
We no longer have return values or any of the mentioned arguments
in these functions since the introduction of CompletionRequest.

llvm-svn: 370174
  • Loading branch information
Teemperor committed Aug 28, 2019
1 parent d15df0e commit 9774a2b
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions lldb/include/lldb/Interpreter/CommandObject.h
Original file line number Diff line number Diff line change
Expand Up @@ -228,25 +228,15 @@ class CommandObject {
///
/// \param[in/out] request
/// The completion request that needs to be answered.
///
/// FIXME: This is the wrong return value, since we also need to make a
/// distinction between
/// total number of matches, and the window the user wants returned.
virtual void HandleCompletion(CompletionRequest &request);

/// The input array contains a parsed version of the line. The insertion
/// point is given by cursor_index (the index in input of the word containing
/// the cursor) and cursor_char_position (the position of the cursor in that
/// word.)
/// The input array contains a parsed version of the line.
///
/// We've constructed the map of options and their arguments as well if that
/// is helpful for the completion.
///
/// \param[in/out] request
/// The completion request that needs to be answered.
///
/// FIXME: This is the wrong return value, since we also need to make a
/// distinction between
/// total number of matches, and the window the user wants returned.
virtual void
HandleArgumentCompletion(CompletionRequest &request,
OptionElementVector &opt_element_vector) {}
Expand Down

0 comments on commit 9774a2b

Please sign in to comment.