Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move HE samples to separate docker layer #190

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

jlhcrawford
Copy link
Contributor

Proposed changes

Separating out the installation of he-samples in Dockerfile.toolkit to its own docker file Dockerfile.samples and making it an optional layer in the docker build.

Types of changes

What types of changes does your code introduce to the HE Toolkit project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING section
  • Current formatting and unit tests / base functionality passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Dockerfile.toolkit now just sets up the hekit command. Making the samples layer optional allows more flexibility for the user to be able to install/build a custom project or subset of the default.toml recipe file.

Signed-off-by: Jack Crawford <jack.crawford@intel.com>
@jlhcrawford jlhcrawford merged commit 859025f into main Feb 27, 2024
11 checks passed
@jlhcrawford jlhcrawford deleted the refactor/docker branch February 27, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants