This repository has been archived by the owner on Jan 28, 2023. It is now read-only.
Fix the potential secure issues from static code scan #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return value of MmGetMdlPfnArray() cannot be NULL according to the macro definition. The condition judgement statement will never be true. Remove the dead code according to the analysis result of Coverity. Signed-off-by: Wenchao Wang <wenchao.wang@intel.com>
HAX_MEM_PAGABLE and HAX_MEM_NONPAGE are mutually exclusive flags. It will be strict to use `else if` instead of `if`. Optimize the code according to the analysis result of Coverity. Signed-off-by: Wenchao Wang <wenchao.wang@intel.com>
The potentially overflowing expression with type int is used to assign to an expression of type uint64_t. Correct the code according to the analysis result of Coverity. Signed-off-by: Wenchao Wang <wenchao.wang@intel.com>
Comment out the unreachable code according to the analysis result of Coverity. Signed-off-by: Wenchao Wang <wenchao.wang@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the security check of the static code scanning tool Coverity, these security patches are made based on the scan results.