-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cgroup support for memory and cpu limiting #56
Conversation
Generally I don't like the terminology of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, not done
I'd like to review it as well, but first let's sync IRL on the purpose and what we try to achieve here, description wasn't clear enough to me |
@michelhe As i stated in the description (todo.2) there is currently another |
It only consists of a single of function, you can just put it in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll complete the pass later. Meanwhile - we still have naming weirdnesses here, so let's define clear names, following https://man7.org/linux/man-pages/man7/cgroups.7.html:
- A cgroup type i.e
memory
,cpu,cpuacct
is calledsubsystem
. Ensure allcgroup_type
andcontroller
are renamed tosubsystem
. (You may also choosecontroller
, I don't mind, but be consistent) - A cgroup path (i.e
/
,/docker/....
) is calledcgroup
- Any other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few last. Please test it as we discussed in private
In this PR:
To Do: