Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

databricks: Add is_databricks() based on /databricks/spark/conf/metrics.properties #262

Merged
merged 2 commits into from
Sep 24, 2024
Merged

databricks: Add is_databricks() based on /databricks/spark/conf/metrics.properties #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
189c1c1
databricks: Add is_databricks() based on /databricks/spark/conf/metri…
Jongy Sep 23, 2024
e94efd2
Merge remote-tracking branch 'origin/master' into databricks-fix
Jongy Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion granulate_utils/metadata/bigdata/bigdatainfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from typing import Optional

from granulate_utils.metadata.bigdata.cloudera import get_cloudera_version
from granulate_utils.metadata.bigdata.databricks import get_databricks_version
from granulate_utils.metadata.bigdata.databricks import get_databricks_version, is_databricks
from granulate_utils.metadata.bigdata.dataproc import get_dataproc_version
from granulate_utils.metadata.bigdata.emr import get_emr_version
from granulate_utils.metadata.bigdata.interfaces import BigDataInfo
Expand All @@ -15,6 +15,8 @@ def get_bigdata_info() -> Optional[BigDataInfo]:
return BigDataInfo("emr", emr_version)
elif databricks_version := get_databricks_version():
return BigDataInfo("databricks", databricks_version)
elif is_databricks():
return BigDataInfo("databricks", "unknown")
elif dataproc_version := get_dataproc_version():
return BigDataInfo("dataproc", dataproc_version)
elif cloudera_version := get_cloudera_version():
Expand Down
10 changes: 10 additions & 0 deletions granulate_utils/metadata/bigdata/databricks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
import logging
import os
from typing import TYPE_CHECKING, Optional, Union

if TYPE_CHECKING:
_LoggerAdapter = logging.LoggerAdapter[logging.Logger]
else:
_LoggerAdapter = logging.LoggerAdapter

DATABRICKS_METRICS_PROP_PATH = "/databricks/spark/conf/metrics.properties"


def get_databricks_version() -> Optional[str]:
try:
Expand All @@ -15,6 +18,13 @@ def get_databricks_version() -> Optional[str]:
return None


def is_databricks() -> bool:
"""
In some Databricks versions / images, /databricks/DBR_VERSION is missing but this file exists.
"""
return os.path.exists(DATABRICKS_METRICS_PROP_PATH)


def get_hadoop_version(logger: Optional[Union[logging.Logger, _LoggerAdapter]]) -> Optional[str]:
try:
with open("/databricks/spark/HADOOP_VERSION", "r") as f:
Expand Down
Loading