Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear psutil's process exe cache #223

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Clear psutil's process exe cache #223

merged 5 commits into from
Jan 16, 2024

Conversation

grariel
Copy link
Contributor

@grariel grariel commented Jan 16, 2024 •
edited by mirikl
Loading

Fix a bug that resulted in psutil's cache. The fix is clearing the cache before using the exe.
Slack thread: https://granulate.slack.com/archives/C05B86W23TK/p1705358435132419

@grariel grariel added the bug Something isn't working label Jan 16, 2024
@grariel grariel requested review from Jongy and mirikl January 16, 2024 09:55
Jongy
Jongy suggested changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@Jongy Jongy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the change, small comment fix

@grariel @Jongy
Update granulate_utils/linux/process.py
3048ce8 
Co-authored-by: Yonatan Goldschmidt <yonatan.goldschmidt@granulate.io>
@grariel grariel requested a review from Jongy January 16, 2024 10:23
Jongy
Jongy approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@Jongy Jongy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is sanity-tested to achieve the desired purpose

mirikl
mirikl approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@mirikl mirikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grariel Can you add a description to the PR?

@grariel grariel merged commit 51a0cf3 into master Jan 16, 2024
7 checks passed
@grariel grariel deleted the bugfix/giampaoloooo branch January 16, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jongy Jongy Jongy approved these changes

@mirikl mirikl mirikl approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grariel @Jongy @mirikl